[webkit-changes] [WebKit/WebKit] c4da3d: AcceleratedSurfaceDMABuf: use a renderbuffer for f...

Žan Doberšek noreply at github.com
Mon Apr 3 06:15:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4da3d5152bddf041e19a90c67d99d77ea92beee
      https://github.com/WebKit/WebKit/commit/c4da3d5152bddf041e19a90c67d99d77ea92beee
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp
    M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.h

  Log Message:
  -----------
  AcceleratedSurfaceDMABuf: use a renderbuffer for fbo color attachment
https://bugs.webkit.org/show_bug.cgi?id=254862

Reviewed by Carlos Garcia Campos.

Don't generate and provide a texture as the color attachment for the custom
framebuffer, use a renderbuffer instead. Instead of a single renderbuffer used
as the color attachment for the framebuffer, with the EGLImage-based storage
being swapped out for each frame, separate renderbuffers are used so that just
the color attachment on the framebuffer changes.

A is-framebuffer-complete check is also done after the framebuffer is set up,
printing out a warning about the incompleteness. This provides the textual
information for why subsequently nothing will be rendered.

* Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:
(WebKit::AcceleratedSurfaceDMABuf::didCreateGLContext):
(WebKit::AcceleratedSurfaceDMABuf::willDestroyGLContext):
(WebKit::AcceleratedSurfaceDMABuf::clientResize):
(WebKit::AcceleratedSurfaceDMABuf::willRenderFrame):
(WebKit::AcceleratedSurfaceDMABuf::didRenderFrame):
* Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.h:

Canonical link: https://commits.webkit.org/262505@main




More information about the webkit-changes mailing list