[webkit-changes] [WebKit/WebKit] 83e92a: HTML parser: only adjust approved SVG and MathML a...

Anne van Kesteren noreply at github.com
Mon Apr 3 01:25:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83e92a3d7ab3fcddacde92972ea1aade639459d3
      https://github.com/WebKit/WebKit/commit/83e92a3d7ab3fcddacde92972ea1aade639459d3
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M LayoutTests/html5lib/resources/tests11.dat
    M LayoutTests/html5lib/resources/webkit02.dat
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11_run_type=uri-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11_run_type=write-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11_run_type=write_single-expected.txt
    M Source/WebCore/WebCore.order
    M Source/WebCore/dom/make_names.pl
    M Source/WebCore/html/parser/HTMLTreeBuilder.cpp
    M Source/WebCore/mathml/mathattrs.in
    M Source/WebCore/svg/SVGElement.cpp
    M Source/WebCore/svg/svgattrs.in
    M Source/WebCore/xml/xmlattrs.in

  Log Message:
  -----------
  HTML parser: only adjust approved SVG and MathML attributes
https://bugs.webkit.org/show_bug.cgi?id=254755
rdar://107428878

Reviewed by Chris Dumez.

Instead of the HTML parser using global lists of SVG, MathML, XLink, and XML attributes, define them locally as the HTML Standard does. As the HTML parser is the sole consumer of these lists that allows them to be smaller and also makes it clearer that any new attributes should follow HTML naming conventions.

Additionally this removes a number of unused attributes:

- SVG contentScriptType
- SVG contentStyleType
- SVG externalResourcesRequired
- XML xml:base

* LayoutTests/html5lib/resources/tests11.dat:
* LayoutTests/html5lib/resources/webkit02.dat:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11_run_type=uri-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11_run_type=write-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11_run_type=write_single-expected.txt:
* Source/WebCore/WebCore.order:
* Source/WebCore/dom/make_names.pl:
(printConstructorInterior):
(upperCaseName):
(printNamesHeaderFile):
(printNamesCppFile):
(printWrapperFactoryHeaderFile):
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::createSVGAttributesMap):
(WebCore::adjustSVGAttributes):
(WebCore::createMathMLAttributesMap):
(WebCore::adjustMathMLAttributes):
(WebCore::createForeignAttributesMap):
(WebCore::createCaseMap): Deleted.
* Source/WebCore/mathml/mathattrs.in:
* Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::childShouldCreateRenderer const):
(WebCore::SVGElement::createAnimator):
(WebCore::SVGElement::animatableAttributeForName):
* Source/WebCore/svg/svgattrs.in:
* Source/WebCore/xml/xmlattrs.in:

Canonical link: https://commits.webkit.org/262502@main




More information about the webkit-changes mailing list