[webkit-changes] [WebKit/WebKit] ce592a: Unreviewed, fix internal Cocoa builds after 262488...

Wenson Hsieh noreply at github.com
Sun Apr 2 16:20:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce592ae3d17e56cb77982e985c56bbdf88e24204
      https://github.com/WebKit/WebKit/commit/ce592ae3d17e56cb77982e985c56bbdf88e24204
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-04-02 (Sun, 02 Apr 2023)

  Changed paths:
    M Source/WebKit/Platform/cocoa/NetworkConnectionIntegrityHelpers.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  -----------
  Unreviewed, fix internal Cocoa builds after 262488 at main

Rename `LookalikeCharacters::Observer` -> `LookalikeCharactersObserver` and move it out of the
`LookalikeCharacters` class namespace, so that it can be forward-declared (and we therefore don't
need to include `NetworkConnectionIntegrityHelpers.h` in `WebPageProxy.h`).

* Source/WebKit/Platform/cocoa/NetworkConnectionIntegrityHelpers.h:
(WebKit::LookalikeCharactersObserver::LookalikeCharactersObserver):
(WebKit::LookalikeCharactersObserver::create):
(WebKit::LookalikeCharactersObserver::invokeCallback):
(WebKit::LookalikeCharacters::cachedStrings const):
(WebKit::LookalikeCharacters::Observer::Observer): Deleted.
(WebKit::LookalikeCharacters::Observer::create): Deleted.
(WebKit::LookalikeCharacters::Observer::invokeCallback): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

Add a missing include for `Logging.h`.

* Source/WebKit/UIProcess/WebPageProxy.cpp:

Move the `NetworkConnectionIntegrityHelpers.h` include to the source file, and also add a missing
include for `WebCore/LookalikeCharactersSanitizationData.h`, which probably wasn't needed before due
to source unification.

* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/262495@main




More information about the webkit-changes mailing list