[webkit-changes] [WebKit/WebKit] 6138f1: Fix some errors reported by cppcheck

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6138f16f5f19831d761f1a85b350eb020d67f0f4
      https://github.com/WebKit/WebKit/commit/6138f16f5f19831d761f1a85b350eb020d67f0f4
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-04-01 (Sat, 01 Apr 2023)

  Changed paths:
    M Source/WTF/wtf/text/SymbolImpl.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp
    M Source/WebCore/platform/graphics/HEVCUtilities.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp
    M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h

  Log Message:
  -----------
  Fix some errors reported by cppcheck
https://bugs.webkit.org/show_bug.cgi?id=254853

Reviewed by Darin Adler.

Fix some errors reported by cppcheck:
```
Source/WTF/wtf/text/SymbolImpl.cpp:41:30: error: Signed integer overflow for expression '1<<31'. [integerOverflow]
    s_nextHashForSymbol |= 1 << 31;
                             ^
Source/WebCore/editing/ReplaceSelectionCommand.cpp:1750:12: error: Reference to local variable returned. [returnReference]
    return list;
           ^
Source/WebCore/platform/graphics/HEVCUtilities.cpp:441:12: error: Uninitialized struct member: parameters.codec [uninitStructMember]
    return parameters;
           ^
Source/WebCore/testing/Internals.cpp:2988:32: warning: Possible null pointer dereference: window [nullPointer]
    auto frontendWindowProxy = window->open(*window, *window, url, emptyAtom(), emptyString()).releaseReturnValue();
                               ^
Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:91:12: error: Reference to local variable returned. [returnReference]
    return downloadProxy;
```

* Source/WTF/wtf/text/SymbolImpl.cpp:
(WTF::SymbolImpl::nextHashForSymbol):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::cssValueKeywordID):
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::deepestSingleChildList):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* Source/WebCore/platform/graphics/HEVCUtilities.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend):
* Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp:
(webkit_network_session_download_uri):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::createDownloadProxy):
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::createDownloadProxy):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::resumeDownload):
(WebKit::WebPageProxy::downloadRequest):
(WebKit::WebPageProxy::contextMenuItemSelected):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::createDownloadProxy):
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::createDownloadProxy):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:

Canonical link: https://commits.webkit.org/262483@main