[webkit-changes] [WebKit/WebKit] 5cd490: Support unclosed parentheses at end of sizes attri...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cd49060d7b3125f95c9a242af7a439177aec7f4
      https://github.com/WebKit/WebKit/commit/5cd49060d7b3125f95c9a242af7a439177aec7f4
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-04-01 (Sat, 01 Apr 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1.html
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2.html
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3.html
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt
    R LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-display-none-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px-expected.txt
    M LayoutTests/platform/glib/TestExpectations
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-display-none-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px-expected.txt
    M LayoutTests/platform/ios-simulator/TestExpectations
    R LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt
    R LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt
    R LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt
    R LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-display-none-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px-expected.txt
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/css/parser/SizesCalcParser.cpp

  Log Message:
  -----------
  Support unclosed parentheses at end of sizes attribute

https://bugs.webkit.org/show_bug.cgi?id=254658

Reviewed by Antti Koivisto.

This patch is to align WebKit with Gecko / Firefox and Blink / Chromium.

Merge - https://chromium.googlesource.com/chromium/src.git/+/8dbf8120062e8edddc1779a3b314f2f4957610e7

Instead of returning false, match unclosed left-parentheses and function tokens.
This progresses about eight test cases (two each) in the WPT test suite.

According to HTML Spec for Parsing Size attribute runs [1] and
calc() parsing [2][3] a component value of it with function ending with EOF-token is valid.

[1] https://html.spec.whatwg.org/multipage/images.html#parse-a-sizes-attribute
[2] https://www.w3.org/TR/css-syntax-3/#parse-a-component-value
[3] https://www.w3.org/TR/css-syntax-3/#consume-a-component-value

Refer to following WPT issue for background: https://github.com/web-platform-tests/wpt/issues/3066

* Source/WebKit/css/parser/SizesCalcParser.cpp:
(SizesCalcParser::calcToReversePolishNotation): Update for 'unclosed' parentheses
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1.html: Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt: Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2.html Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt: Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3.html: Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt: Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4.html: Deleted
* LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt: Deleted
* LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt: Deleted
* LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt: Deleted
* LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt: Deleted
* LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt: Deleted
* LayoutTests/TestExpectations: Remove WPT Test Exceptions
* LayoutTests/platform/mac/TestExpectations:Remove WPT Test Exceptions
* LayoutTests/platform/glib/TestExpectations: Remove WPT Test Exceptions
* LayoutTests/platform/ios-simulator/TestExpectations: Remove WPT Test Exceptions
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-display-none-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-display-none-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode-expected.txt: Add Platform Specific Expectations
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px-expected.txt: Add Platform Specific Expectations
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-display-none-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt: Deleted (Without test and it is not on WPT)

Canonical link: https://commits.webkit.org/262477@main