[webkit-changes] [WebKit/WebKit] 25abb3: Do not expose -webkit-text CSS value in quirks mode
Tim Nguyen
noreply at github.com
Tue Sep 27 16:46:46 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25abb3d63d29b09a7101e02001a721f2cb04815a
https://github.com/WebKit/WebKit/commit/25abb3d63d29b09a7101e02001a721f2cb04815a
Author: Tim Nguyen <ntim at apple.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
A LayoutTests/fast/css/internal-document-text-color-unexposed-expected.html
A LayoutTests/fast/css/internal-document-text-color-unexposed.html
A LayoutTests/fast/css/webkit-text-quirks-mode-expected.html
A LayoutTests/fast/css/webkit-text-quirks-mode.html
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/StyleColor.cpp
M Source/WebCore/css/parser/CSSParserIdioms.cpp
M Source/WebCore/css/quirks.css
M Source/WebCore/style/StyleBuilderState.cpp
Log Message:
-----------
Do not expose -webkit-text CSS value in quirks mode
https://bugs.webkit.org/show_bug.cgi?id=154164
Reviewed by Sam Weinig.
Rename -webkit-text value for color to -internal-document-text-color and only expose it for UA sheets.
Test: LayoutTests/fast/css/webkit-text-quirks-mode.html & LayoutTests/fast/css/internal-document-text-color-unexposed.html
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/StyleColor.cpp:
(WebCore::StyleColor::isSystemColorKeyword):
* Source/WebCore/css/parser/CSSParserIdioms.cpp:
(WebCore::isValueAllowedInMode):
* Source/WebCore/css/quirks.css:
(table):
* Source/WebCore/style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::isColorFromPrimitiveValueDerivedFromElement):
(WebCore::Style::BuilderState::colorFromPrimitiveValue const):
* LayoutTests/fast/css/internal-document-text-color-unexposed-expected.html: Added.
* LayoutTests/fast/css/internal-document-text-color-unexposed.html: Added.
* LayoutTests/fast/css/webkit-text-quirks-mode-expected.html: Added.
* LayoutTests/fast/css/webkit-text-quirks-mode.html: Added.
Canonical link: https://commits.webkit.org/254935@main
More information about the webkit-changes
mailing list