[webkit-changes] [WebKit/WebKit] 0a4bde: [WGSL] Gardening of WGSL parser unit tests
Dan Glastonbury
noreply at github.com
Tue Sep 27 16:08:30 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0a4bde8f1d82ae6a0a5fa0db6ef1855c485f45e5
https://github.com/WebKit/WebKit/commit/0a4bde8f1d82ae6a0a5fa0db6ef1855c485f45e5
Author: Dan Glastonbury <djg at apple.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M Source/WebGPU/WGSL/AST/Expressions/StructureAccess.h
M Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm
M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp
M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp
Log Message:
-----------
[WGSL] Gardening of WGSL parser unit tests
https://bugs.webkit.org/show_bug.cgi?id=245654
rdar://problem/100397595
Reviewed by Myles C. Maxfield.
Gardening of unit tests, including:
- Add full parsing tests for complete sample vertex and fragment shaders.
- Use XCTAssertTrue & XCTAssertEqual instead of XCTAssert.
- Refactor tests to use auto& instead of doubling up on type names.
- Add functions for common AST checks.
* Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm:
(-[WGSLParserTests testParsingStruct]):
(-[WGSLParserTests testParsingGlobalVariable]):
(-[WGSLParserTests testParsingFunctionDecl]):
(-[WGSLParserTests testTrivialGraphicsShader]):
(-[WGSLParserTests testParsingLocalVariable]):
(-[WGSLParserTests testParsingArrayAccess]):
(-[WGSLParserTests testParsingUnaryExpression]):
(-[WGSLParserTests testParsingTriangleVert]):
(-[WGSLParserTests testParsingRedFrag]):
Canonical link: https://commits.webkit.org/254932@main
More information about the webkit-changes
mailing list