[webkit-changes] [WebKit/WebKit] d7f19f: [LFC][IFC] fix fast/block/float/022.html

alan noreply at github.com
Tue Sep 27 14:49:16 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7f19f513f314c3f98bec52c5457f299957e7cf5
      https://github.com/WebKit/WebKit/commit/d7f19f513f314c3f98bec52c5457f299957e7cf5
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-27 (Tue, 27 Sep 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h
    M Source/WebCore/rendering/style/RenderStyle.h

  Log Message:
  -----------
  [LFC][IFC] fix fast/block/float/022.html
https://bugs.webkit.org/show_bug.cgi?id=245740

Reviewed by Antti Koivisto.

1. Move top/left static position computation over to InlineFormattingGeometry.
2. Add basic support for block level boxes and place them where they would go if they were inflow e.g.
We layout the following content:
  <div>some text<div out-of-flow></div>some more text</div>
as if it was
  <div>
    <div anon>some text</div>
    <div out-of-flow></div
    <div anon>some more text</div>
  </div>

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeStaticPositionForOutOfFlowContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox const):
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowBlockLevelBox const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::isDisplayBlockLevel const):
(WebCore::RenderStyle::isOriginalDisplayBlockType const):
(WebCore::RenderStyle::isDisplayBlockType):

Canonical link: https://commits.webkit.org/254930@main




More information about the webkit-changes mailing list