[webkit-changes] [WebKit/WebKit] 03f310: [Cocoa] NetworkSessionCocoa::createWebSocketTask c...

Wenson Hsieh noreply at github.com
Tue Sep 27 07:30:15 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03f310261d6cc7d8e206a9885752800e654483b7
      https://github.com/WebKit/WebKit/commit/03f310261d6cc7d8e206a9885752800e654483b7
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2022-09-27 (Tue, 27 Sep 2022)

  Changed paths:
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  -----------
  [Cocoa] NetworkSessionCocoa::createWebSocketTask creates up to 4 copies of the given URL request
https://bugs.webkit.org/show_bug.cgi?id=245711

Reviewed by Tim Horton.

Address a FIXME in `NetworkSessionCocoa::createWebSocketTask`; we clone the original URL request at
most once by instead lazily creating the mutable copy. This prevents us from needlessly copying the
request when two or more of the following are true:

- The protocol is non-null
- The request isn't app initiated
- Privacy proxy is disabled
- The main frame main resource was private relayed

No change in behavior.

* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):

Canonical link: https://commits.webkit.org/254911@main




More information about the webkit-changes mailing list