[webkit-changes] [WebKit/WebKit] aabdfc: Fix strokeStyle changes not being applied for succ...

mattwoodrow noreply at github.com
Mon Sep 26 19:20:14 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aabdfc49a52bb7286b4325975ccfaabdcf74d907
      https://github.com/WebKit/WebKit/commit/aabdfc49a52bb7286b4325975ccfaabdcf74d907
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    A LayoutTests/fast/canvas/canvas-strokePath-strokeStyle-expected.html
    A LayoutTests/fast/canvas/canvas-strokePath-strokeStyle.html
    M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp

  Log Message:
  -----------
  Fix strokeStyle changes not being applied for successive stroke line operations.
https://bugs.webkit.org/show_bug.cgi?id=245465

Reviewed by Darin Adler.

The recordStrokeLineWithColorAndThickness optimised path skips serialising the state object, but fails to mark that we've applied the necessary changes.

This means that you can then change state back to it's original value, and we won't detect that it changed.

* LayoutTests/fast/canvas/canvas-strokePath-strokeStyle-expected.html: Added.
* LayoutTests/fast/canvas/canvas-strokePath-strokeStyle.html: Added.
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::strokePath):

Canonical link: https://commits.webkit.org/254889@main




More information about the webkit-changes mailing list