[webkit-changes] [WebKit/WebKit] 76836c: [LFC] Remove LineBreakBox layout box type

Antti Koivisto noreply at github.com
Mon Sep 26 08:20:17 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76836cf59fae568337623bc4fce07221efae5abc
      https://github.com/WebKit/WebKit/commit/76836cf59fae568337623bc4fce07221efae5abc
  Author: Antti Koivisto <antti at apple.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.h
    R Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp
    R Source/WebCore/layout/layouttree/LayoutLineBreakBox.h
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
    M Source/WebCore/layout/layouttree/LayoutTreeBuilder.h

  Log Message:
  -----------
  [LFC] Remove LineBreakBox layout box type
https://bugs.webkit.org/show_bug.cgi?id=245662
<rdar://100401549>

Reviewed by Alan Bujtas.

It can be represented by an element type and doesn't need a separate class.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::handleInlineLevelBox):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTreeForInlineContent):
* Source/WebCore/layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isLineBreakBox const):
(WebCore::Layout::Box::isWordBreakOpportunity const):
(WebCore::Layout::Box::isInlineTextBox const):
* Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp: Removed.
* Source/WebCore/layout/layouttree/LayoutLineBreakBox.h: Removed.
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::TreeBuilder::createLineBreakBox): Deleted.
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.h:

Canonical link: https://commits.webkit.org/254860@main




More information about the webkit-changes mailing list