[webkit-changes] [WebKit/WebKit] 156274: Merge 254848 at main - Hulu.com content is stretched ...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 15627421d9c2dbde893679099050316fa4603796
      https://github.com/WebKit/WebKit/commit/15627421d9c2dbde893679099050316fa4603796
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h

  Log Message:
  -----------
  Merge 254848 at main - Hulu.com content is stretched when moving to next episode
https://bugs.webkit.org/show_bug.cgi?id=245641
<rdar://100199996>

Reviewed by Eric Carlson.

As a prelude: at some point, WebKit fixed a bug where the `object-fit` CSS property was not honored
if set before media began loading in a HTMLVideoElement. Hulu.com sets it's video element's
`object-fit:` style to `fill`. When Hulu.com navigates to the next episode in a playlist, it resets
the <video>'s `width:` and `height:` style to 100%, causing the video to stretch visibly. Previous
to the mentioned fix, this bug would "hide" this behavior, by causing the renderer to ignore `fill`
and default to `contain`.

Add a quirk for Hulu.com that reverts to the previous (broken) behavior.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateMediaPlayer):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsVideoShouldMaintainAspectRatioQuirk const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/254848@main

(cherry picked from commit 249fdd9c0f8bf064190f69a2791917b762922bee)


  Commit: e362e6b6f47fb0f8682e81bf696c11c6a04406bf
      https://github.com/WebKit/WebKit/commit/e362e6b6f47fb0f8682e81bf696c11c6a04406bf
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M Tools/glib/apply-build-revision-to-files.py

  Log Message:
  -----------
  Merge 254851 at main - [GLib] Modernize Tools/glib/apply-build-revision-to-files.py
https://bugs.webkit.org/show_bug.cgi?id=242191
<rdar://problem/96245384>

Reviewed by Michael Catanzaro.

Switch back to git log parsing, as before 252012 at main. Using webkitpy was not a great idea for two
reasons:

- autoinstall kicking off during offline builds and failing
- SSL issues in buildroot setups.

* Tools/glib/apply-build-revision-to-files.py:
(get_revision_from_most_recent_git_commit):
(get_build_revision):
(main):

Canonical link: https://commits.webkit.org/254851@main

(cherry picked from commit 792d6325aedb3d164f2f4a2d139523b0f7ffab02)


Compare: https://github.com/WebKit/WebKit/compare/9980be90d8de...e362e6b6f47f