[webkit-changes] [WebKit/WebKit] 04f52d: Don't suppress click event on textarea resize

Ahmad Saleem noreply at github.com
Sun Sep 25 12:27:40 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04f52dabffd1c9cc991c935b659d47352f61c291
      https://github.com/WebKit/WebKit/commit/04f52dabffd1c9cc991c935b659d47352f61c291
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-09-25 (Sun, 25 Sep 2022)

  Changed paths:
    A LayoutTests/fast/events/mouse-events-on-textarea-resize-expected.txt
    A LayoutTests/fast/events/mouse-events-on-textarea-resize.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/page/EventHandler.cpp

  Log Message:
  -----------
  Don't suppress click event on textarea resize

Don't suppress click event on textarea resize

https://bugs.webkit.org/show_bug.cgi?id=245617

Reviewed by Aditya Keerthi.

This is to align Webkit behavior with all other browser engines Gecko / Firefox and Blink / Chromium.

As Webkit does send both mousedown and mouseup for a textarea while resizing it might as well send the click event.

Merge - https://chromium.googlesource.com/chromium/src.git/+/add02c1e965eccadef4ee43d99d5dfc0083afa23

* Source/WebCore/page/EventHandler.cpp:
(EventHandler::handlerMousePressEvent): Remove "invalidateClick" to enable "Click" events
* LayoutTests/fast/event/mouse-events-on-textarea-resize.html: Added Test Case
* LayoutTests/fast/event/mouse-events-on-textarea-resize-expected.txt: Added Test Case Expectations
* LayoutTests/platform/ios/TestExpectations: Updated to skip added test on iOS Platform due to lack of resizer support

Canonical link: https://commits.webkit.org/254843@main




More information about the webkit-changes mailing list