[webkit-changes] [WebKit/WebKit] 09df07: Update named colors list to match CSS Color 4
Sam Weinig
noreply at github.com
Sun Sep 25 08:39:03 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 09df074a4a8861c5fa7ba160368f6fb1ea1890b0
https://github.com/WebKit/WebKit/commit/09df074a4a8861c5fa7ba160368f6fb1ea1890b0
Author: Sam Weinig <weinig at apple.com>
Date: 2022-09-25 (Sun, 25 Sep 2022)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/system-color-valid-expected.txt
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/StyleColor.cpp
M Source/WebCore/css/StyleColor.h
M Source/WebCore/css/html.css
M Source/WebCore/rendering/RenderTheme.cpp
Log Message:
-----------
Update named colors list to match CSS Color 4
https://bugs.webkit.org/show_bug.cgi?id=245533
<rdar://100287586>
Reviewed by Darin Adler.
Added new system colors from CSS Color 4 with the following default
platform agnostic values:
ButtonBorder
white (matching existing ActiveBorder and InactiveBorder values).
SelectedItem
lightGray (matching existing Menu value)
SelectedItemText
black (matching existing *Text values)
Mark
yellow (matching background-color of <mark> in UA stylesheet)
MarkText
black (matching color of <mark> in UA stylesheet)
AccentColor
sRGB { 0, 122, 255 } (matching color of system-control-accent)
AccentColorText
black (matching existing *Text values)
As with other system colors, it may make sense to specialize
these per-platform, but this change does not aim to do that.
Also re-organized CSSValueKeywords.in to group some related
color names together, and added comments to help clarify what
set things belong to.
As a way of organizing, and in preparation for an upcoming
change to deprecated system colors, the deprecated system
colors were grouped together and a helper function added.
As we now have a named colors Mark and MarkText, the UA stylesheet
for <mark> was updated to use the named colors (no observable
change in behavior though, as the colors still resolve to yellow
and black).
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/StyleColor.cpp:
(WebCore::isVGAPaletteColor):
(WebCore::StyleColor::isAbsoluteColorKeyword):
(WebCore::StyleColor::isSystemColorKeyword):
(WebCore::StyleColor::isDeprecatedSystemColorKeyword):
* Source/WebCore/css/StyleColor.h:
* Source/WebCore/css/html.css:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor const):
Canonical link: https://commits.webkit.org/254840@main
More information about the webkit-changes
mailing list