[webkit-changes] [WebKit/WebKit] fc4a52: Omit the integer value for grid-lines when it's th...

mattwoodrow noreply at github.com
Fri Sep 23 23:32:18 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc4a525dc1504f16c392e5f6a3936f56f085e410
      https://github.com/WebKit/WebKit/commit/fc4a525dc1504f16c392e5f6a3936f56f085e410
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt
    M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html
    M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt
    M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html
    M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt
    M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed.html
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  Omit the integer value for grid-lines when it's the default value.
https://bugs.webkit.org/show_bug.cgi?id=245025

Reviewed by Tim Nguyen.

As per the shortest possible serialization principle, we don't need to print the '1' default value.

* LayoutTests/fast/css-grid-layout/grid-item-area-get-set-expected.txt:
* LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html:
* LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
* LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html:
* LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
* LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html:
* LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
* LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-computed.html:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForGridPosition):

Canonical link: https://commits.webkit.org/254821@main




More information about the webkit-changes mailing list