[webkit-changes] [WebKit/WebKit] 889e6f: Merge 254716 at main - Do not launch network process ...

Adrian Perez noreply at github.com
Fri Sep 23 11:24:19 PDT 2022


  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 889e6ff6237900bec264ec2bac4d7d9aee1c3661
      https://github.com/WebKit/WebKit/commit/889e6ff6237900bec264ec2bac4d7d9aee1c3661
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp

  Log Message:
  -----------
  Merge 254716 at main - Do not launch network process if not necessary in WebLoaderStrategy
https://bugs.webkit.org/show_bug.cgi?id=245442
<rdar://100187344>

Reviewed by Geoffrey Garen.

We currently ensure network process connection in web process when sending IsResourceLoadFinished, RemoveLoadIdentifier,
PageLoadCompleted and BrowsingContextRemoved messages. This means if network process does not exist (e.g. due to crash),
we will relaunch it. But the newly launched network process won't have information about loads in previous network
process, so web process should not need to wait for network process to be launched in these cases. (Note we still
ensure network process connection when network process is actually needed, e.g. starting a load or setting load
parameters.)

* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::remove):
(WebKit::WebLoaderStrategy::pageLoadCompleted):
(WebKit::WebLoaderStrategy::browsingContextRemoved):
(WebKit::WebLoaderStrategy::isResourceLoadFinished):

Canonical link: https://commits.webkit.org/254716@main

(cherry picked from commit ae9067a992640619f66b670e3eb64f9cc0eb3ff5)


  Commit: 8dfb704940a3c86ade5184e747f5a0feedfeb397
      https://github.com/WebKit/WebKit/commit/8dfb704940a3c86ade5184e747f5a0feedfeb397
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityAtspi.h

  Log Message:
  -----------
  Merge 254722 at main - Prevent calling an AT-SPI observer from invalidating map iterators
https://bugs.webkit.org/show_bug.cgi?id=245214

Reviewed by Carlos Garcia Campos.

* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::notify const):
(WebCore::AccessibilityAtspi::notifyStateChanged const):
(WebCore::AccessibilityAtspi::notifySelectionChanged const):
(WebCore::AccessibilityAtspi::notifyMenuSelectionChanged const):
(WebCore::AccessibilityAtspi::notifyTextChanged const):
(WebCore::AccessibilityAtspi::notifyTextCaretMoved const):
(WebCore::AccessibilityAtspi::notifyValueChanged const):
(WebCore::AccessibilityAtspi::notifyLoadEvent const):
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.h:

Canonical link: https://commits.webkit.org/254722@main

(cherry picked from commit f170deb7670205b57a795284f19361010e8a4207)


  Commit: b35b86e2a5ee8780708f7b1cfa75b57beae273da
      https://github.com/WebKit/WebKit/commit/b35b86e2a5ee8780708f7b1cfa75b57beae273da
  Author: Enrique Ocaña González <eocanha at igalia.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M Source/WebCore/Modules/mediasource/SourceBuffer.cpp

  Log Message:
  -----------
  Merge 254781 at main - [MSE] Adjust buffering rate monitor to react faster
https://bugs.webkit.org/show_bug.cgi?id=245486

Reviewed by Xabier Rodriguez-Calvar.

As data is comming in (in bursts), the buffering rate monitoring algorithm calculates an
average rate that will be used to determine if we can play through the content without
interruption (assuming relatively constant rate). To filter out variations in rate, the
algorithm reacts more slowly (by design) and may take more time to reach the required rate
threshold to unblock playback, even though the incoming rate is sufficient to sustain
playback. If it takes too long, then a client using MSE may take corrective actions wich may
disturb or even abort the playback.

By adjusting the 'ExponentialMovingAverageCoefficient' we can make the algorithm react
faster to presence of data and unblock playback. Side effect is that it reacts also faster
to absence of data, but that should not affect playback as data has been buffered already
allowing playback to be sustained.

Original author: Pawel Lampe <pawel.lampe at gmail.com>
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/927
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/928

* Source/WebCore/Modules/mediasource/SourceBuffer.cpp: Adjust ExponentialMovingAverageCoefficient from 0.1 to 0.2.

Canonical link: https://commits.webkit.org/254781@main

(cherry picked from commit 68d7d604b06e9bc2658348bb6960ab3886851b9f)


  Commit: 74982ab7a01bb1934f89513cba9250af93df3716
      https://github.com/WebKit/WebKit/commit/74982ab7a01bb1934f89513cba9250af93df3716
  Author: Przemyslaw Gorszkowski <pgorszkowski at igalia.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
    M Source/cmake/OptionsGTK.cmake
    M Source/cmake/OptionsWPE.cmake

  Log Message:
  -----------
  Merge 254721 at main - [GStreamer][MSE][CMake] Limit video support to 1080p at 30fps on RaspberryPi
https://bugs.webkit.org/show_bug.cgi?id=245270

Reviewed by Adrian Perez de Castro and Xabier Rodriguez-Calvar.

* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/254721@main

(cherry picked from commit 9d318e8396da78d13f59f006803d8d1a77a0d8b4)


  Commit: 3d19bee5161e6a6d71379171521b558f65004c6d
      https://github.com/WebKit/WebKit/commit/3d19bee5161e6a6d71379171521b558f65004c6d
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGOperations.cpp
    M Source/WebCore/dom/EventLoop.cpp
    M Source/WebCore/html/canvas/ImageBitmapRenderingContext.h
    M Source/WebCore/layout/floats/FloatingState.cpp
    M Source/WebCore/layout/formattingContexts/FormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/FormattingQuirks.cpp
    M Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp
    M Source/WebKit/UIProcess/gtk/KeyBindingTranslator.h

  Log Message:
  -----------
  Merge 254786 at main - Non-unified build fixes, late September 2022 edition

Unreviewed non-unified build fixes.

Based on an initial patch from Lauro Moura.

* Source/JavaScriptCore/dfg/DFGOperations.cpp: Add missing
  InterpreterInlines.h header inclusion.
* Source/WebCore/bindings/js/JSElementInternalsCustom.cpp: Added a bunch
  of missing header inclusions.
* Source/WebCore/css/ComputedStyleExtractor.cpp: Add missing
  CSSProperty.h header inclusion.
* Source/WebCore/dom/CustomElementDefaultARIA.cpp: Add missing
  Element.h, HTMLNames.h, and SpaceSplitString.h header inclusions.
* Source/WebCore/dom/CustomElementDefaultARIA.h: Add missing forward
  declaration f or the Element type.
* Source/WebCore/dom/EventLoop.cpp: Add missing ScriptExecutionContext.h
  header inclusion.
* Source/WebCore/html/canvas/ImageBitmapRenderingContext.h: Add missing
  forward declaration of the OffscreenCanvas type.
* Source/WebCore/layout/floats/FloatingState.cpp: Add missing
  LayoutContainingBlockChainIterator.h header inclusion, remove
  inclusions of other headers which are brought in transitively.
* Source/WebCore/layout/formattingContexts/FormattingContext.cpp: Add
  missing LayoutContainingBlockChainIterator.h header inclusion.
* Source/WebCore/layout/formattingContexts/FormattingQuirks.cpp: Ditto.
* Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h:
  Add missing FormattingContext.h header inclusion.
* Source/WebCore/platform/WebCorePersistentCoders.h: Add missing
  <optional> header inclusion.
* Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp:
(WTF::Persistence::Coder<WebKit::NetworkCache::Key>::decode): Add
  WebKit::NetworkCache:: namespace prefixes where missing.
(WTF::Persistence::Coder<WebKit::NetworkCache::SubresourceInfo>::decode):
  Ditto.
* Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:
  Add missing wtf/persistence/PersistentEncoder.h header inclusion.
* Source/WebKit/UIProcess/gtk/KeyBindingTranslator.h: Add missing
  wtf/glib/GRefPtr.h header inclusion.

Canonical link: https://commits.webkit.org/254786@main

(cherry picked from commit 0c765655518c1eb49a302430158bb0592e1d53d0)


Compare: https://github.com/WebKit/WebKit/compare/2e028d1ca2cf...3d19bee5161e


More information about the webkit-changes mailing list