[webkit-changes] [WebKit/WebKit] 1f231e: Blending between two rotateZ() transform values sh...

Antoine Quint noreply at github.com
Fri Sep 23 02:55:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f231e23b766bea941685230a80dd4eae1776573
      https://github.com/WebKit/WebKit/commit/1f231e23b766bea941685230a80dd4eae1776573
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-inline-value-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h
    M Source/WebCore/platform/graphics/transforms/TransformOperation.cpp
    M Source/WebCore/platform/graphics/transforms/TransformOperation.h

  Log Message:
  -----------
  Blending between two rotateZ() transform values should serialize as rotate3d()
https://bugs.webkit.org/show_bug.cgi?id=245527

Reviewed by Antti Koivisto.

We didn't have a way to differentiate a rotation provided as rotateZ() rather than rotate().
We now keep a distinct OperationType value for ROTATE_Z and ensure we never simplify to the
ROTATE type in the primitiveType() override of RotateTransformOperation.

We also fix computedTransform() to correctly use the angle rather than the individual axis
for the rotateX/Y/Z functions.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-inline-value-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computedTransform):
* Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h:
* Source/WebCore/platform/graphics/transforms/TransformOperation.cpp:
* Source/WebCore/platform/graphics/transforms/TransformOperation.h:

Canonical link: https://commits.webkit.org/254782@main




More information about the webkit-changes mailing list