[webkit-changes] [WebKit/WebKit] 7e2faa: [ New Test ] (254561 at main): [ macOS wk2 ] fast/scr...

Richard Robinson noreply at github.com
Thu Sep 22 17:08:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e2faa9cf5dc8594be90a966883eada469238a7f
      https://github.com/WebKit/WebKit/commit/7e2faa9cf5dc8594be90a966883eada469238a7f
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M LayoutTests/fast/scrolling/mac/keyboard-scrolling-with-mouse-scroll.html
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  [ New Test ] (254561 at main): [ macOS wk2 ] fast/scrolling/mac/keyboard-scrolling-with-mouse-scroll.html is a flaky failure (245482)
https://bugs.webkit.org/show_bug.cgi?id=245503
rdar://100227233

Reviewed by Aditya Keerthi.

The original test was flaky because it depended on the scroll position after
a duration of time using `setTimeout`. However, because this is not guaranteed,
the scroll position could vary, causing the test assertion to fail.

This PR fixes this issue by measuring the scroll position relative to the
position immediately after the key up event, which gets rid of this possible
variation.

Additionally, this PR improves upon the original test by having the wheel event
have no delta scroll position; it is only important for the test that the wheel
event properly interrupts the keyboard scrolling. This also removes a possible
vector of variation.

* LayoutTests/fast/scrolling/mac/keyboard-scrolling-with-mouse-scroll.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254771@main




More information about the webkit-changes mailing list