[webkit-changes] [WebKit/WebKit] 89eea2: Add support for DictionaryPopupInfo in the new IPC...

Gavin noreply at github.com
Thu Sep 22 16:20:45 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89eea21b4ef219726324da09a77312748f7688f0
      https://github.com/WebKit/WebKit/commit/89eea21b4ef219726324da09a77312748f7688f0
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M Source/WebCore/editing/DictionaryPopupInfo.h
    M Source/WebCore/editing/cocoa/DictionaryLookup.mm
    M Source/WebCore/editing/mac/DictionaryLookupLegacy.mm
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources-output.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
    A Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
    M Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp
    M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
    M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Add support for DictionaryPopupInfo in the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=245471
rdar://100219507

Reviewed by Alex Christensen.

Add support for DictionaryPopupInfo in the new IPC serialization format.
This change also includes adding support for referencing Objective-C types
in the GeneratedSerializer files.

* Source/WebCore/editing/DictionaryPopupInfo.h:
(WebCore::DictionaryPopupInfo::encodingRequiresPlatformData const): Deleted.
* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
* Source/WebCore/editing/mac/DictionaryLookupLegacy.mm:
(WebCore::showPopupOrCreateAnimationController):
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Scripts/generate-serializers.py:
(generate_impl):
(parse_serialized_types):
(main):
(generate_cpp): Deleted.
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.serialization.in: Added.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::decode):
(IPC::ArgumentCoder<DictionaryPopupInfo>::encode): Deleted.
(IPC::ArgumentCoder<DictionaryPopupInfo>::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _animationControllerForText]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin):
* Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm:
(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
(-[WebImmediateActionController _animationControllerForText]):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
(-[WebView _showDictionaryLookupPopup:]):

Canonical link: https://commits.webkit.org/254768@main




More information about the webkit-changes mailing list