[webkit-changes] [WebKit/WebKit] 1cd3b0: Merge 254699 at main - document.open() should abort a...

Sihui noreply at github.com
Thu Sep 22 14:47:05 PDT 2022


  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cd3b03835c8f51a369e86a6b68ee316fa87029b
      https://github.com/WebKit/WebKit/commit/1cd3b03835c8f51a369e86a6b68ee316fa87029b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-refresh-immediate.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/loader/NavigationScheduler.cpp
    M Source/WebCore/loader/NavigationScheduler.h

  Log Message:
  -----------
  Merge 254699 at main - document.open() should abort all loads when the document is navigating
https://bugs.webkit.org/show_bug.cgi?id=245407

Reviewed by Youenn Fablet.

document.open() should abort all loads when the document is navigating or there is a queued navigation:
- https://github.com/whatwg/html/issues/3975

This aligns our behavior with Blink and Gecko, as they already already passing those WPT tests.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-refresh-immediate.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::open):
* Source/WebCore/loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::hasQueuedNavigation const):
* Source/WebCore/loader/NavigationScheduler.h:

Canonical link: https://commits.webkit.org/254699@main

(cherry picked from commit 952f3c7c8ab8baa4279db4a804712201c998c389)


  Commit: f69252981440748eba056d107d04ce5ce89a5813
      https://github.com/WebKit/WebKit/commit/f69252981440748eba056d107d04ce5ce89a5813
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    A LayoutTests/fast/html/abbr-acronym-rendering-expected.html
    A LayoutTests/fast/html/abbr-acronym-rendering.html
    M Source/WebCore/css/html.css

  Log Message:
  -----------
  Merge 254710 at main - Align "UA" stylesheet for "abbr" and "acronym" with HTML Spec
https://bugs.webkit.org/show_bug.cgi?id=245441

Reviewed by Alan Bujtas.

This is to align "UA" stylesheet with HTML Specifications:

https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3

We were missing following styling for:

> abbr
> acronym

Merge for Test Case - https://chromium.googlesource.com/chromium/src.git/+/fb579cdb6aa334f44e57072a3c1fd803aa2cb082

* Source/WebCore/css/html.css: Add missing "abbr" and "acronym" styling in UA stylesheet
* LayoutTests/fast/html/abbr-acronym-rendering.html: Added Test Case from Chrome Patch
* LayoutTests/fast/html/abbr-acronym-rendering-expected.html: Added Test Case Expectations

Canonical link: https://commits.webkit.org/254710@main

(cherry picked from commit 543702eba9948fbaf1c8c032661e14e69560be9d)


  Commit: 2e028d1ca2cf0ea4459359d3f178360e3036c97a
      https://github.com/WebKit/WebKit/commit/2e028d1ca2cf0ea4459359d3f178360e3036c97a
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/workers/WorkerScriptLoader.cpp
    M Source/WebCore/workers/service/ServiceWorkerProvider.cpp
    M Source/WebCore/workers/service/ServiceWorkerProvider.h
    M Source/WebCore/workers/service/WorkerSWClientConnection.cpp
    M Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp
    M Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm

  Log Message:
  -----------
  Merge 254707 at main - Do not launch network process for sending unregisterServiceWorkerClient
https://bugs.webkit.org/show_bug.cgi?id=245434
<rdar://100177915>

Reviewed by Youenn Fablet.

The newly launched network process will have no information about clients connected to previous network process.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::unregisterReservedServiceWorkerClient):
* Source/WebCore/workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::~WorkerScriptLoader):
* Source/WebCore/workers/service/ServiceWorkerProvider.cpp:
(WebCore::ServiceWorkerProvider::singleton):
* Source/WebCore/workers/service/ServiceWorkerProvider.h:
* Source/WebCore/workers/service/WorkerSWClientConnection.cpp:
(WebCore::WorkerSWClientConnection::unregisterServiceWorkerClient):
* Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::WebServiceWorkerProvider::existingServiceWorkerConnection):
* Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(waitAndGetNextMessage):
(TEST):
(terminateWorker):
(-[BroadcastChannelMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.

Canonical link: https://commits.webkit.org/254707@main

(cherry picked from commit a189c5a83b2317bc64a054fb62a9c8cac6126c7c)


Compare: https://github.com/WebKit/WebKit/compare/189b20b439ac...2e028d1ca2cf


More information about the webkit-changes mailing list