[webkit-changes] [WebKit/WebKit] 8f927a: Make custom elements's default ARIA id-ref work wi...
Ryosuke Niwa
noreply at github.com
Thu Sep 22 11:47:15 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8f927ad0d4312332b9c76c0b2219e02da04a202b
https://github.com/WebKit/WebKit/commit/8f927ad0d4312332b9c76c0b2219e02da04a202b
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2022-09-22 (Thu, 22 Sep 2022)
Changed paths:
A LayoutTests/accessibility/custom-elements/controls-shadow-expected.txt
A LayoutTests/accessibility/custom-elements/controls-shadow.html
A LayoutTests/accessibility/custom-elements/describedby-shadow-expected.txt
A LayoutTests/accessibility/custom-elements/describedby-shadow.html
A LayoutTests/accessibility/custom-elements/flowto-shadow-expected.txt
A LayoutTests/accessibility/custom-elements/flowto-shadow.html
A LayoutTests/accessibility/custom-elements/menuitem-shadow-expected.txt
A LayoutTests/accessibility/custom-elements/menuitem-shadow.html
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/dom/CustomElementDefaultARIA.cpp
Log Message:
-----------
Make custom elements's default ARIA id-ref work with shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=245467
Reviewed by Manuel Rego Casasnovas.
Make ElementInternals's id-ref ARIA attributes work with shadow DOM by recursively updating
relations between AX objects in AXObjectCache::updateRelationsIfNeeded.
* LayoutTests/accessibility/custom-elements/controls-shadow-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/controls-shadow.html: Added.
* LayoutTests/accessibility/custom-elements/describedby-shadow-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/describedby-shadow.html: Added.
* LayoutTests/accessibility/custom-elements/flowto-shadow-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/flowto-shadow.html: Added.
* LayoutTests/accessibility/custom-elements/menuitem-shadow-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/menuitem-shadow.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateRelationsIfNeeded):
(WebCore::AXObjectCache::updateRelationsForTree): Extracted from updateRelationsIfNeeded.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/dom/CustomElementDefaultARIA.cpp:
(WebCore::isElementVisible): Fixed a bug that this function returns false when
"thisElement" is disconnected but element is in the document tree.
Canonical link: https://commits.webkit.org/254762@main
More information about the webkit-changes
mailing list