[webkit-changes] [WebKit/WebKit] bb50e5: ViewUpdate*, Event*, WebInspectorInterruptDispatch...

Kimmo Kinnunen noreply at github.com
Thu Sep 22 03:12:21 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb50e5a9e92cf937d06a193f9dd48c03395e506a
      https://github.com/WebKit/WebKit/commit/bb50e5a9e92cf937d06a193f9dd48c03395e506a
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.cpp
    M Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.h
    M Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.messages.in
    M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
    M Source/WebKit/WebProcess/WebPage/EventDispatcher.h
    M Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in
    M Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.cpp
    M Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.h
    M Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.messages.in
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  -----------
  ViewUpdate*, Event*, WebInspectorInterruptDispatcher should be MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=245068
rdar://problem/99816958

Reviewed by Antti Koivisto.

These objects are never destroyed, and as such should not be refcounted.

Use addMessageReceiver when adding the work queue message receivers.

This is work towards simplifying IPC::Connection by working towards
removing addWorkQueueMessageReceiver().

* Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.cpp:
(WebKit::WebInspectorInterruptDispatcher::initializeConnection):
(WebKit::WebInspectorInterruptDispatcher::create): Deleted.
* Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.h:
* Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.messages.in:
* Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::initializeConnection):
(WebKit::EventDispatcher::internalWheelEvent):
(WebKit::EventDispatcher::gestureEvent):
(WebKit::EventDispatcher::touchEvent):
(WebKit::EventDispatcher::dispatchWheelEventViaMainThread):
(WebKit::EventDispatcher::create): Deleted.
* Source/WebKit/WebProcess/WebPage/EventDispatcher.h:
(WebKit::EventDispatcher::queue): Deleted.
* Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in:
* Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::initializeConnection):
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::create): Deleted.
* Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.h:
(WebKit::ViewUpdateDispatcher::UpdateData::UpdateData): Deleted.
* Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::displayWasRefreshed):
* Source/WebKit/WebProcess/WebProcess.h:
(WebKit::WebProcess::eventDispatcher):

Canonical link: https://commits.webkit.org/254753@main




More information about the webkit-changes mailing list