[webkit-changes] [WebKit/WebKit] f1bbab: [IFC][Integration] Tighten up float support checki...

alan noreply at github.com
Wed Sep 21 21:35:37 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1bbab6ed2939f331abf80b7b0440bff944802db
      https://github.com/WebKit/WebKit/commit/f1bbab6ed2939f331abf80b7b0440bff944802db
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M LayoutTests/platform/ios/fast/lists/001-vertical-expected.txt
    M LayoutTests/platform/mac/fast/lists/001-vertical-expected.txt
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [IFC][Integration] Tighten up float support checking with mismatching inline direction
https://bugs.webkit.org/show_bug.cgi?id=245485

Reviewed by Antti Koivisto.

Enable the mismatching inline direction check (and extend it to rtl) for any content. It means that we fallback to legacy line layout when an intrusive float is coming from either a mismatching or rtl parent regardless of whether the current IFC has floats.

<div style="direction: rtl">
  <div style="float: left"></div>
  modern line layout
</div>

is still IFC while

<div style="direction: rtl">
  <div style="float: left"></div>
  <div style="direction: ltr">legacy line layout</div>
</div>

is legacy.

* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

Canonical link: https://commits.webkit.org/254749@main




More information about the webkit-changes mailing list