[webkit-changes] [WebKit/WebKit] ba43b9: Regression(242214) ViewSnapshotStore's snapshots a...

[Patrick Angle]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba43b95d6427f9b488bbc19b33099c2b1a2db659
      https://github.com/WebKit/WebKit/commit/ba43b95d6427f9b488bbc19b33099c2b1a2db659
  Author: Patrick Angle <pangle at apple.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/ViewSnapshotStore.cpp

  Log Message:
  -----------
  Regression(242214) ViewSnapshotStore's snapshots are no longer volatile
https://bugs.webkit.org/show_bug.cgi?id=245490

Reviewed by Tim Horton.

Bug 242214 stopped marking view snapshots as volatile by default in order for WebDriver to guarantee their lifetime
until it is able to convert it to base64. This causes the ViewSnapshotStore to grow to it's limit of 400mb, instead of
being able to have snapshots disposed of sooner. The ViewSnapshotStore should explicitly mark the snapshots it takes as
volatile to satisfy that requirement.

* Source/WebKit/UIProcess/ViewSnapshotStore.cpp:
(WebKit::ViewSnapshotStore::recordSnapshot):

Canonical link: https://commits.webkit.org/254734@main