[webkit-changes] [WebKit/WebKit] 3f576a: IPC::Connection declaration has unrelated platform...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f576a1763a5651d3609d6d364fa109fd915a2f3
      https://github.com/WebKit/WebKit/commit/3f576a1763a5651d3609d6d364fa109fd915a2f3
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h
    M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
    M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
    M Source/WebKit/NetworkProcess/webrtc/RTCDataChannelRemoteManagerProxy.h
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Platform/IPC/Connection.h
    M Source/WebKit/Platform/IPC/IPCUtilities.h
    A Source/WebKit/Platform/IPC/MessageObserver.h
    M Source/WebKit/Platform/IPC/MessageReceiveQueues.h
    A Source/WebKit/Platform/IPC/WorkQueueMessageReceiver.h
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
    M Source/WebKit/Platform/IPC/win/ConnectionWin.cpp
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
    M Source/WebKit/UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp
    M Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp
    M Source/WebKit/UIProcess/mac/SecItemShimProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.h
    M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h
    M Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h
    M Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.h
    M Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.h
    M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
    M Source/WebKit/WebProcess/WebPage/EventDispatcher.h
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
    M Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.h
    M Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.h

  Log Message:
  -----------
  IPC::Connection declaration has unrelated platform implementation declarations
https://bugs.webkit.org/show_bug.cgi?id=245178
rdar://problem/99916528

Reviewed by Antti Koivisto.

Move inner-classes to standalone classes in their own headers:
 - MessageObserver
 - WorkQueueMessageReceiver

Move platform-specific pipe and socket creation functions to
IPCtilities.h.

This way IPC::Connection declaration is easier to understand.

* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
* Source/WebKit/NetworkProcess/webrtc/RTCDataChannelRemoteManagerProxy.h:
* Source/WebKit/Platform/IPC/Connection.cpp:
* Source/WebKit/Platform/IPC/Connection.h:
* Source/WebKit/Platform/IPC/IPCUtilities.h:
* Source/WebKit/Platform/IPC/MessageObserver.h: Copied from Source/WebKit/Platform/IPC/IPCUtilities.h.
* Source/WebKit/Platform/IPC/MessageReceiveQueues.h:
* Source/WebKit/Platform/IPC/WorkQueueMessageReceiver.h: Copied from Source/WebKit/Platform/IPC/IPCUtilities.h.
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::createPlatformConnection):
(IPC::Connection::createConnectionIdentifierPair):
(IPC::Connection::createPlatformConnection): Deleted.
* Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:
(IPC::createServerAndClientIdentifiers):
(IPC::Connection::createConnectionIdentifierPair):
(IPC::Connection::createServerAndClientIdentifiers): Deleted.
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/UIProcess/mac/SecItemShimProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.h:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
* Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h:
* Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.h:
* Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.h:
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h:
* Source/WebKit/WebProcess/WebPage/EventDispatcher.h:
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
* Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.h:
* Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.h:

Canonical link: https://commits.webkit.org/254728@main