[webkit-changes] [WebKit/WebKit] b17ccd: Add leak tests for NodeIterator and TreeWalker

Ryosuke Niwa noreply at github.com
Tue Sep 20 21:39:26 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b17ccd4f3712b8d42d1113ec3f26423005b28806
      https://github.com/WebKit/WebKit/commit/b17ccd4f3712b8d42d1113ec3f26423005b28806
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    A LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect-expected.txt
    A LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html
    A LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document-expected.txt
    A LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html
    A LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document-expected.txt
    A LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html
    A LayoutTests/fast/dom/resources/leak-check.js

  Log Message:
  -----------
  Add leak tests for NodeIterator and TreeWalker
https://bugs.webkit.org/show_bug.cgi?id=119718

Reviewed by Darin Adler, Geoffrey Garen and Chris Dumez.

Add the leak tests based on https://chromium.googlesource.com/chromium/blink/+/65db79784ecd4a7e744d10a26befe5159638a56c
These tests have been modified to account for the fact WebKit / JSC uses a conservative GC as opposed to V8's precise GC.

* LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect-expected.txt: Added.
* LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html: Added.
* LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document-expected.txt: Added.
* LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html: Added.
* LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document-expected.txt: Added.
* LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html: Added.
* LayoutTests/fast/dom/resources/leak-check.js: Added.
(getCounterValues):
(loadSourceIntoIframe):
(async doLeakTest):
(htmlToUrl):
(grabScriptText):

Canonical link: https://commits.webkit.org/254711@main




More information about the webkit-changes mailing list