[webkit-changes] [WebKit/WebKit] bae60f: [webkitpy] Use canonical-id in suggestnominations

Diego Pino noreply at github.com
Tue Sep 20 17:08:17 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bae60fe2c5a7a0942f0440a004d6ec489e42f963
      https://github.com/WebKit/WebKit/commit/bae60fe2c5a7a0942f0440a004d6ec489e42f963
  Author: Diego Pino Garcia <dpino at igalia.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M Tools/Scripts/webkitpy/tool/commands/suggestnominations.py
    M Tools/Scripts/webkitpy/tool/commands/suggestnominations_unittest.py

  Log Message:
  -----------
  [webkitpy] Use canonical-id in suggestnominations
https://bugs.webkit.org/show_bug.cgi?id=245277

Reviewed by Jonathan Bedard.

Since WebKit moved to GitHub, commit messages no longer include the
'svn-id' trailer, which was used to compile statistics about number of
commits of potential commiter and reviewer candidates.  This identifier
should now be replaced by 'canonical-id'.

The committer message regular expression had to be modified as it was
failing many times and not all commit messages were processed. Also do
not raise exception if committer could not be found contributors list.

* Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:
(AbstractCommitLogCommand):
(AbstractCommitLogCommand._parse_commit_message):
(SuggestNominations._count_commit):
* Tools/Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
(SuggestNominationsTest):

Canonical link: https://commits.webkit.org/254701@main




More information about the webkit-changes mailing list