[webkit-changes] [WebKit/WebKit] 3ed0f4: `KeyboardScrollingAnimator::updateKeyboardScrollPo...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ed0f4e841a4a7adf1243ced93eb72604c7bb501
      https://github.com/WebKit/WebKit/commit/3ed0f4e841a4a7adf1243ced93eb72604c7bb501
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    A LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates-expected.txt
    A LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html
    M Source/WebCore/platform/KeyboardScrollingAnimator.cpp

  Log Message:
  -----------
  `KeyboardScrollingAnimator::updateKeyboardScrollPosition` is called indefinitely when using keyboard smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=245403
rdar://100146415

Reviewed by Tim Horton and Simon Fraser.

When the `EventHandler driven smooth scrolling` flag is enabled,
`KeyboardScrollingAnimator::updateKeyboardScrollPosition` is called indefinitely,
causing the scroll to never terminate.

Regression from https://github.com/WebKit/WebKit/commit/8c822fa15adbdecd22d0c3ece07c9e9aa2260af1
which accidentally removed the logic of settng `m_scrollTriggeringKeyIsPressed` to `false`.

* Source/WebCore/platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::handleKeyUpEvent):

Canonical link: https://commits.webkit.org/254685@main