[webkit-changes] [WebKit/WebKit] fe4b1d: [LFC][Cleanup] Remove Layout::Box::isInFormattingC...

[alan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe4b1d3bf61e8999ccd68da789905e92f8ffc9e3
      https://github.com/WebKit/WebKit/commit/fe4b1d3bf61e8999ccd68da789905e92f8ffc9e3
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M Source/WebCore/layout/floats/FloatingState.cpp
    M Source/WebCore/layout/floats/FloatingState.h
    M Source/WebCore/layout/layouttree/LayoutBox.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.h

  Log Message:
  -----------
  [LFC][Cleanup] Remove Layout::Box::isInFormattingContextOf
https://bugs.webkit.org/show_bug.cgi?id=245364

Reviewed by Antti Koivisto.

This looks very much like a block margin collapsing/float box only function. If it becomes required by some other layout operations, we should move it over to FormattingContext class and not back to Layout::Box.
This patch is also in preparation for removing containingBlock and friends from Layout::Box.

* Source/WebCore/layout/floats/FloatingState.cpp:
(WebCore::Layout::FloatingState::FloatItem::isInFormattingContextOf const):
* Source/WebCore/layout/floats/FloatingState.h:
(WebCore::Layout::FloatingState::FloatItem::isInFormattingContextOf const): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isInFormattingContextOf const): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.h:

Canonical link: https://commits.webkit.org/254681@main