[webkit-changes] [WebKit/WebKit] ec1b26: Fix !elementStyle.caretColor().isValid() check in ...

Tim Nguyen noreply at github.com
Tue Sep 20 04:23:47 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec1b260043e4f44ad017340db926319d4f75f45f
      https://github.com/WebKit/WebKit/commit/ec1b260043e4f44ad017340db926319d4f75f45f
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M Source/WebCore/editing/FrameSelection.cpp

  Log Message:
  -----------
  Fix !elementStyle.caretColor().isValid() check in FrameSelection.cpp
https://bugs.webkit.org/show_bug.cgi?id=245421
<rdar://100166424>

Reviewed by Antti Koivisto.

The intent here is really to check if the value is `auto`, so using `hasAutoCaretColor()` makes it more explicit.
This also makes refactoring Color to StyleColor easier.

* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::computeCaretColor):

Canonical link: https://commits.webkit.org/254668@main




More information about the webkit-changes mailing list