[webkit-changes] [WebKit/WebKit] c2c849: Add platform-specific expectations of http/tests/s...

Fujii Hironori noreply at github.com
Tue Sep 20 00:25:46 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2c84973bcac41b074f403d01bfe1991d2112d0e
      https://github.com/WebKit/WebKit/commit/c2c84973bcac41b074f403d01bfe1991d2112d0e
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M LayoutTests/http/tests/scroll-to-text-fragment/start-text-emoji.html
    M LayoutTests/http/tests/scroll-to-text-fragment/start-text-quote.html
    M LayoutTests/http/tests/scroll-to-text-fragment/start-text-sentence.html
    M LayoutTests/http/tests/scroll-to-text-fragment/start-text-word.html
    A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html
    A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-quote-expected.html
    A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html
    A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-word-expected.html
    R LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html
    R LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html
    R LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-word-expected.html
    A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html
    A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-quote-expected.html
    A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html
    A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-word-expected.html

  Log Message:
  -----------
  Add platform-specific expectations of http/tests/scroll-to-text-fragment ref-tests for WinCairo, GTK and WPE ports
https://bugs.webkit.org/show_bug.cgi?id=245055

Reviewed by Darin Adler.

http/tests/scroll-to-text-fragment ref-tests were failing for GTK port
because GTK port's expectations had the incorrect annotation highlight
color. The actual annotation highlight color is calculated by
transforming the color returned by
RenderTheme::platformAnnotationHighlightColor. The actual color is
yellow with 80% alpha.

Fixed GTK port's expectations. Added glib ports' expectations by
moving them for WPE port. Added WinCairo expectations by copying them.

* LayoutTests/http/tests/scroll-to-text-fragment/start-text-emoji.html:
* LayoutTests/http/tests/scroll-to-text-fragment/start-text-quote.html:
* LayoutTests/http/tests/scroll-to-text-fragment/start-text-sentence.html:
* LayoutTests/http/tests/scroll-to-text-fragment/start-text-word.html:
* LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html.
* LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-quote-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html.
* LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html.
* LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-word-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-word-expected.html.
* LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html: Renamed from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html.
* LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-quote-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html.
* LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html: Renamed from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html.
* LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-word-expected.html: Renamed from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-word-expected.html.

Canonical link: https://commits.webkit.org/254664@main




More information about the webkit-changes mailing list