[webkit-changes] [WebKit/WebKit] 662e9f: [JSC] HeapBigInt CompareStrictEq should call use a...

Yusuke Suzuki noreply at github.com
Mon Sep 19 19:14:26 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 662e9f67690eac1d94556207cea3186159996337
      https://github.com/WebKit/WebKit/commit/662e9f67690eac1d94556207cea3186159996337
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-09-19 (Mon, 19 Sep 2022)

  Changed paths:
    A JSTests/stress/osr-exit-check-node-liveness-heap-bigint-strict-eq.js
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

  Log Message:
  -----------
  [JSC] HeapBigInt CompareStrictEq should call use after speculation checks
https://bugs.webkit.org/show_bug.cgi?id=233682
rdar://86192953

Reviewed by Saam Barati.

Because we call use() before speculation check, in OSR exit, these nodes may be counted as dead, which can make
OSR exit recovering for these node's loc to undefined. We should call `use()` after possible OSR exit (in this case,
speculation).

* JSTests/stress/osr-exit-check-node-liveness-heap-bigint-strict-eq.js: Added.
(shouldBe):
(main.v29):
(main):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

Canonical link: https://commits.webkit.org/254655@main




More information about the webkit-changes mailing list