[webkit-changes] [WebKit/WebKit] 9c004a: Remove quirk: Floating list-items are display:block

Ahmad Saleem noreply at github.com
Mon Sep 19 13:46:47 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c004a6b5b1ab0e2b920b1b0df0702f73fd76dc7
      https://github.com/WebKit/WebKit/commit/9c004a6b5b1ab0e2b920b1b0df0702f73fd76dc7
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-09-19 (Mon, 19 Sep 2022)

  Changed paths:
    A LayoutTests/fast/css/quirks-mode-ignore-list-item-expected.txt
    A LayoutTests/fast/css/quirks-mode-ignore-list-item.html
    M LayoutTests/platform/glib/fast/lists/001-expected.txt
    M LayoutTests/platform/gtk/fast/lists/001-expected.png
    M LayoutTests/platform/gtk/fast/lists/001-vertical-expected.png
    M LayoutTests/platform/ios/fast/lists/001-expected.txt
    M LayoutTests/platform/ios/fast/lists/001-vertical-expected.txt
    M LayoutTests/platform/mac/fast/lists/001-expected.png
    M LayoutTests/platform/mac/fast/lists/001-expected.txt
    M LayoutTests/platform/mac/fast/lists/001-vertical-expected.png
    M LayoutTests/platform/mac/fast/lists/001-vertical-expected.txt
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  Remove quirk: Floating list-items are display:block

Remove quirk: Floating list-items are display:block

https://bugs.webkit.org/show_bug.cgi?id=245336

Reviewed by Alan Bujtas.

This patch remove quirk mode which was added to be compatible with Internet Explorer while it was not available in EdgeHTML and was never added by Firefox / Gecko. This was also later dropped by Chrome / Blink.

Partial Merge - https://chromium.googlesource.com/chromium/src.git/+/06ae6f0489cf8efa87e7190ab90940b62a998c8b

Currently in quirks mode, and element with float set and display set to list-item is forced to be display:block. This current action is not supported in quirks spec and is inconsistent with FF/Edge. This patch fixes that behavior and allows these elements to retain their display value even in quirks mode.

* Source/WebCore/style/StyleAdjuster.cpp:
(equivalentBlockDisplay): Removed "document"
(DisplayType equivalentBlockDisplay): Remove WinIE quirks for DisplayType::ListItem
(Adjuster:adjust): Removed "m_document"
* LayoutTests/fast/css/quirks-mode-ignore-list-item.html: Added Test Case
* LayoutTests/fast/css/quirks-mode-ignore-list-item-expected.txt: Add Test Case Expectations
* LayoutTests/platform/glib/fast/lists/001-expected.txt: Updated Test Expectations
* LayoutTests/platform/ios/fast/lists/001-expected.txt: Updated Test Expectations
* LayoutTests/platform/ios/fast/lists/001-vertical-expected.txt: Updated Test Expectations
* LayoutTests/platform/gtk/fast/lists/001-expected.png: Updated Test Expectations
* LayoutTests/platform/gtk/fast/lists/001-vertical-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/lists/001-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/lists/001-expected.txt: Updated Test Expectations
* LayoutTests/platform/mac/fast/lists/001-vertical-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/lists/001-vertical-expected.txt: Updated Test Expectations

Canonical link: https://commits.webkit.org/254643@main




More information about the webkit-changes mailing list