[webkit-changes] [WebKit/WebKit] 61b684: AX: Focus state cannot be read or updated for Acce...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61b68425a2b484f2680d340ca998c38395d8d5fd
      https://github.com/WebKit/WebKit/commit/61b68425a2b484f2680d340ca998c38395d8d5fd
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-09-18 (Sun, 18 Sep 2022)

  Changed paths:
    A LayoutTests/accessibility/basic-focusability-expected.txt
    A LayoutTests/accessibility/basic-focusability.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

  Log Message:
  -----------
  AX: Focus state cannot be read or updated for AccessibilityNodeObjects
https://bugs.webkit.org/show_bug.cgi?id=245308
rdar://problem/100055122

Reviewed by Chris Fleizach.

AccessibilityRenderObject has implementations of `isFocused` and
`setFocused`, but AccessibilityNodeObject does not. Because these
implementations don't actually require a renderer, only a node, this
patch moves them to AccessibilityNodeObject.

This allows AX clients to read and update the focus state of
AccessibilityNodeObjects.

* LayoutTests/accessibility/basic-focusability-expected.txt: Added.
* LayoutTests/accessibility/basic-focusability.html: Added.
* LayoutTests/platform/glib/TestExpectations: Disable new test.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
* LayoutTests/platform/win/TestExpectations: Disable new test.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isFocused const):
(WebCore::AccessibilityNodeObject::setFocused):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFocused const): Deleted.
(WebCore::AccessibilityRenderObject::setFocused): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityIsFocusedForTesting]):
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::isFocused const):

Canonical link: https://commits.webkit.org/254618@main