[webkit-changes] [WebKit/WebKit] b8caa5: REGRESSION(254574 at main): Triggers ASSERTS when run...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8caa5b21cd31bbc7cb929c59e387f9d3fb59219
      https://github.com/WebKit/WebKit/commit/b8caa5b21cd31bbc7cb929c59e387f9d3fb59219
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-09-18 (Sun, 18 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  REGRESSION(254574 at main): Triggers ASSERTS when running wpt tests
https://bugs.webkit.org/show_bug.cgi?id=245333

Reviewed by Michael Catanzaro.

Since 254574 at main the WebPageProxy TextIndicator methods are actually called on all ports, including
the ones not supporting this feature. Using ASSERT_NOT_REACHED() for unimplemented features is
un-common as well, usually notImplemented() is used instead, so do so for these code paths.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setTextIndicator):
(WebKit::WebPageProxy::clearTextIndicator):
(WebKit::WebPageProxy::setTextIndicatorAnimationProgress):

Canonical link: https://commits.webkit.org/254610@main