[webkit-changes] [WebKit/WebKit] fc8671: [IFC][Integration] Convert logical float box coord...
alan
noreply at github.com
Sat Sep 17 09:33:30 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc86717936477c70c76408b658a392f4c0dfe5e5
https://github.com/WebKit/WebKit/commit/fc86717936477c70c76408b658a392f4c0dfe5e5
Author: Alan Bujtas <zalan at apple.com>
Date: 2022-09-17 (Sat, 17 Sep 2022)
Changed paths:
A LayoutTests/fast/block/float/float-vertical-rtl-margin-expected.html
A LayoutTests/fast/block/float/float-vertical-rtl-margin.html
M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h
Log Message:
-----------
[IFC][Integration] Convert logical float box coordinates to visual to support vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=245303
Reviewed by Antti Koivisto.
1. Introduce BoxGeometry::geometryForWritingModeAndDirection to be able to flip logical box geometry to visual.
2. Make sure we don't override the existing logical box geometry.
3. Convert logical float box coordinates to visual including vertical mode and rtl direction.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processFloatBoxes):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::constructContent):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::geometryForWritingMode const):
Canonical link: https://commits.webkit.org/254589@main
More information about the webkit-changes
mailing list