[webkit-changes] [WebKit/WebKit] 1460c1: [CMake] Add option to compile with warnings as errors

Don Olmstead noreply at github.com
Fri Sep 16 22:35:02 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1460c1507d3b1749f6e55193c8fe48f343877249
      https://github.com/WebKit/WebKit/commit/1460c1507d3b1749f6e55193c8fe48f343877249
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    M Source/cmake/WebKitCompilerFlags.cmake
    M Source/cmake/WebKitMacros.cmake
    M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  -----------
  [CMake] Add option to compile with warnings as errors
https://bugs.webkit.org/show_bug.cgi?id=155047

Reviewed by Michael Catanzaro.

Add `DEVELOPER_MODE_FATAL_WARNINGS` as an option to compile everything
defined through `WEBKIT_TARGET` with warnings as errors. For MSVC
`/WX` is added for everything else `-Werror` is used. An additional
flag, `--[no-]fatal-warnings` was added to the `build-webkit` script.

This value should be set to `ON` by default but is currently turned
`OFF` until the build bots invoke `build-webkit` with
`--no-fatal-warnings`. After that it should be turned to `ON`.

* Source/cmake/WebKitCompilerFlags.cmake:
* Source/cmake/WebKitMacros.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/254583@main




More information about the webkit-changes mailing list