[webkit-changes] [WebKit/WebKit] 4a97e1: Add layout test coverage for the Permissions API

Rupin Mittal noreply at github.com
Fri Sep 16 10:43:45 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a97e14f958d62ac96bc6e7a847ef8815cebd140
      https://github.com/WebKit/WebKit/commit/4a97e14f958d62ac96bc6e7a847ef8815cebd140
  Author: Rupin Mittal <rmittal2 at apple.com>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-dedicated-worker-expected.txt
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-dedicated-worker.html
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-dedicated-worker.js
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-service-worker-expected.txt
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-service-worker.html
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-service-worker.js
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-shared-worker-expected.txt
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-shared-worker.html
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-shared-worker.js
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-window-expected.txt
    A LayoutTests/http/tests/permissions/permission-status-onchange-event-window.html
    A LayoutTests/http/tests/permissions/permissions-query-dedicated-workers-expected.txt
    A LayoutTests/http/tests/permissions/permissions-query-dedicated-workers.html
    A LayoutTests/http/tests/permissions/permissions-query-dedicated-workers.js
    A LayoutTests/http/tests/permissions/permissions-query-service-worker-expected.txt
    A LayoutTests/http/tests/permissions/permissions-query-service-worker.html
    A LayoutTests/http/tests/permissions/permissions-query-service-worker.js
    A LayoutTests/http/tests/permissions/permissions-query-shared-worker-expected.txt
    A LayoutTests/http/tests/permissions/permissions-query-shared-worker.html
    A LayoutTests/http/tests/permissions/permissions-query-shared-worker.js
    A LayoutTests/http/tests/permissions/permissions-query-window-expected.txt
    A LayoutTests/http/tests/permissions/permissions-query-window.html
    R LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event-expected.txt
    R LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event.html
    R LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event.js
    R LayoutTests/http/tests/permissions/shared-worker-permission-status-onchange-event-expected.txt
    R LayoutTests/http/tests/permissions/shared-worker-permission-status-onchange-event.html
    R LayoutTests/http/tests/permissions/shared-worker-permission-status-onchange-event.js
    R LayoutTests/http/tests/permissions/worker-permission-status-onchange-event-expected.txt
    R LayoutTests/http/tests/permissions/worker-permission-status-onchange-event.html
    R LayoutTests/http/tests/permissions/worker-permission-status-onchange-event.js
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Add layout test coverage for the Permissions API
https://bugs.webkit.org/show_bug.cgi?id=245239

Reviewed by Sihui Liu.

Previously, Permissions API functionality was only being tested in macOS wk2
because the permission state being queried for was that of the Notifications API,
which is available only on macOS. This patch adds test coverage for all wk2 platforms
by querying for the permission state of the Geolocation API, which is available on
all wk2 platforms.

* LayoutTests/http/tests/permissions/permission-status-onchange-event-dedicated-worker-expected.txt: Renamed from LayoutTests/http/tests/permissions/worker-permission-status-onchange-event-expected.txt.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-dedicated-worker.html: Renamed from LayoutTests/http/tests/permissions/worker-permission-status-onchange-event.html.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-dedicated-worker.js: Renamed from LayoutTests/http/tests/permissions/worker-permission-status-onchange-event.js.
(onmessage):
* LayoutTests/http/tests/permissions/permission-status-onchange-event-service-worker-expected.txt: Copied from LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event-expected.txt.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-service-worker.html: Renamed from LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event.html.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-service-worker.js: Renamed from LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event.js.
(self.onmessage):
* LayoutTests/http/tests/permissions/permission-status-onchange-event-shared-worker-expected.txt: Renamed from LayoutTests/http/tests/permissions/shared-worker-permission-status-onchange-event-expected.txt.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-shared-worker.html: Renamed from LayoutTests/http/tests/permissions/shared-worker-permission-status-onchange-event.html.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-shared-worker.js: Renamed from LayoutTests/http/tests/permissions/shared-worker-permission-status-onchange-event.js.
(port.onmessage):
(onconnect):
* LayoutTests/http/tests/permissions/permission-status-onchange-event-window-expected.txt: Added.
* LayoutTests/http/tests/permissions/permission-status-onchange-event-window.html: Added.
* LayoutTests/http/tests/permissions/permissions-query-dedicated-workers-expected.txt: Copied from LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event-expected.txt.
* LayoutTests/http/tests/permissions/permissions-query-dedicated-workers.html: Added.
* LayoutTests/http/tests/permissions/permissions-query-dedicated-workers.js: Added.
(onmessage):
* LayoutTests/http/tests/permissions/permissions-query-service-worker-expected.txt: Copied from LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event-expected.txt.
* LayoutTests/http/tests/permissions/permissions-query-service-worker.html: Added.
* LayoutTests/http/tests/permissions/permissions-query-service-worker.js: Added.
(self.onmessage):
* LayoutTests/http/tests/permissions/permissions-query-shared-worker-expected.txt: Renamed from LayoutTests/http/tests/permissions/service-worker-permission-status-onchange-event-expected.txt.
* LayoutTests/http/tests/permissions/permissions-query-shared-worker.html: Added.
* LayoutTests/http/tests/permissions/permissions-query-shared-worker.js: Added.
(port.onmessage):
(onconnect):
* LayoutTests/http/tests/permissions/permissions-query-window-expected.txt: Added.
* LayoutTests/http/tests/permissions/permissions-query-window.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::queryPermission):

Canonical link: https://commits.webkit.org/254562@main




More information about the webkit-changes mailing list