[webkit-changes] [WebKit/WebKit] 341101: Add the support for string reflections on ElementI...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 341101190ec82f392260c91d397d571b97661621
      https://github.com/WebKit/WebKit/commit/341101190ec82f392260c91d397d571b97661621
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    A LayoutTests/accessibility/custom-elements/autocomplete-expected.txt
    A LayoutTests/accessibility/custom-elements/autocomplete.html
    A LayoutTests/accessibility/custom-elements/current-expected.txt
    A LayoutTests/accessibility/custom-elements/current.html
    A LayoutTests/accessibility/custom-elements/heading-expected.txt
    A LayoutTests/accessibility/custom-elements/heading.html
    A LayoutTests/accessibility/custom-elements/hidden-button-expected.txt
    A LayoutTests/accessibility/custom-elements/hidden-button.html
    A LayoutTests/accessibility/custom-elements/liveregions-expected.txt
    A LayoutTests/accessibility/custom-elements/liveregions.html
    A LayoutTests/accessibility/custom-elements/menuitem-expected.txt
    A LayoutTests/accessibility/custom-elements/menuitem.html
    A LayoutTests/accessibility/custom-elements/modal-expected.txt
    A LayoutTests/accessibility/custom-elements/modal.html
    A LayoutTests/accessibility/custom-elements/multiselectable-expected.txt
    A LayoutTests/accessibility/custom-elements/multiselectable.html
    A LayoutTests/accessibility/custom-elements/orientation-expected.txt
    A LayoutTests/accessibility/custom-elements/orientation.html
    A LayoutTests/accessibility/custom-elements/posinset-expected.txt
    A LayoutTests/accessibility/custom-elements/posinset.html
    A LayoutTests/accessibility/custom-elements/pressed-expected.txt
    A LayoutTests/accessibility/custom-elements/pressed.html
    M LayoutTests/accessibility/custom-elements/role-expected.txt
    M LayoutTests/accessibility/custom-elements/role.html
    A LayoutTests/accessibility/custom-elements/slider-expected.txt
    A LayoutTests/accessibility/custom-elements/slider.html
    A LayoutTests/accessibility/custom-elements/table-expected.txt
    A LayoutTests/accessibility/custom-elements/table.html
    A LayoutTests/accessibility/custom-elements/textbox-expected.txt
    A LayoutTests/accessibility/custom-elements/textbox.html
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-accessibility-expected.txt
    M LayoutTests/platform/gtk/TestExpectations
    A LayoutTests/platform/gtk/accessibility/custom-elements/autocomplete-expected.txt
    A LayoutTests/platform/gtk/accessibility/custom-elements/hidden-button-expected.txt
    A LayoutTests/platform/gtk/accessibility/custom-elements/modal-expected.txt
    A LayoutTests/platform/gtk/accessibility/custom-elements/pressed-expected.txt
    A LayoutTests/platform/gtk/accessibility/custom-elements/table-expected.txt
    A LayoutTests/platform/gtk/accessibility/custom-elements/textbox-expected.txt
    A LayoutTests/platform/mac-wk1/accessibility/custom-elements/current-expected.txt
    A LayoutTests/platform/mac-wk1/accessibility/custom-elements/hidden-button-expected.txt
    A LayoutTests/platform/mac-wk1/accessibility/custom-elements/liveregions-expected.txt
    A LayoutTests/platform/mac-wk1/accessibility/custom-elements/table-expected.txt
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/dom/CustomElementDefaultARIA.cpp
    M Source/WebCore/dom/CustomElementDefaultARIA.h
    M Source/WebCore/dom/ElementInternals.cpp
    M Source/WebCore/dom/ElementInternals.h
    M Source/WebCore/dom/ElementInternals.idl
    M Source/WebCore/dom/QualifiedName.h

  Log Message:
  -----------
  Add the support for string reflections on ElementInternals
https://bugs.webkit.org/show_bug.cgi?id=245028

Reviewed by Chris Fleizach.

Added the rest of string reflections on ElementInternals.
Also use Reflect IDL attribute on ElementInternals to share more code between attributes.

* LayoutTests/accessibility/custom-elements/autocomplete-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/autocomplete.html: Added.
* LayoutTests/accessibility/custom-elements/current-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/current.html: Added.
* LayoutTests/accessibility/custom-elements/heading-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/heading.html: Added.
* LayoutTests/accessibility/custom-elements/hidden-button-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/hidden-button.html: Added.
* LayoutTests/accessibility/custom-elements/liveregions-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/liveregions.html: Added.
* LayoutTests/accessibility/custom-elements/menuitem-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/menuitem.html: Added.
* LayoutTests/accessibility/custom-elements/modal-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/modal.html: Added.
* LayoutTests/accessibility/custom-elements/multiselectable-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/multiselectable.html: Added.
* LayoutTests/accessibility/custom-elements/orientation-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/orientation.html: Added.
* LayoutTests/accessibility/custom-elements/posinset-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/posinset.html: Added.
* LayoutTests/accessibility/custom-elements/pressed-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/pressed.html: Added.
* LayoutTests/accessibility/custom-elements/role-expected.txt:
* LayoutTests/accessibility/custom-elements/role.html:
* LayoutTests/accessibility/custom-elements/slider-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/slider.html: Added.
* LayoutTests/accessibility/custom-elements/table-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/table.html: Added.
* LayoutTests/accessibility/custom-elements/textbox-expected.txt: Added.
* LayoutTests/accessibility/custom-elements/textbox.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-accessibility-expected.txt: Rebaselined.
* LayoutTests/platform/gtk/accessibility/custom-elements/autocomplete-expected.txt: Added.
* LayoutTests/platform/gtk/accessibility/custom-elements/hidden-button-expected.txt: Added.
* LayoutTests/platform/gtk/accessibility/custom-elements/modal-expected.txt: Added.
* LayoutTests/platform/gtk/accessibility/custom-elements/pressed-expected.txt: Added.
* LayoutTests/platform/gtk/accessibility/custom-elements/table-expected.txt: Added.
* LayoutTests/platform/gtk/accessibility/custom-elements/textbox-expected.txt: Added.
* LayoutTests/platform/mac-wk1/accessibility/custom-elements/current-expected.txt: Added.
* LayoutTests/platform/mac-wk1/accessibility/custom-elements/hidden-button-expected.txt: Added.
* LayoutTests/platform/mac-wk1/accessibility/custom-elements/liveregions-expected.txt: Added.
* LayoutTests/platform/mac-wk1/accessibility/custom-elements/table-expected.txt: Added.
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/win/TestExpectations:

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::isModalElement const): Added a fallback for default ARIA
(WebCore::nodeHasRole): Ditto.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasAttribute const): Ditto.
(WebCore::AccessibilityObject::getAttribute const):

* Source/WebCore/dom/CustomElementDefaultARIA.cpp:
(WebCore::CustomElementDefaultARIA::setValueForAttribute): Use QualifiedName instead of
AtomString for the mapping attributes.
(WebCore::CustomElementDefaultARIA::valueForAttribute const): Ditto.
(WebCore::CustomElementDefaultARIA::hasAttribute const): Added.

* Source/WebCore/dom/CustomElementDefaultARIA.h:
(WebCore::CustomElementDefaultARIA):

* Source/WebCore/dom/ElementInternals.cpp:
(WebCore::ElementInternals::setRole): Deleted.
(WebCore::ElementInternals::role): Deleted.
(WebCore::ElementInternals::setAriaRoleDescription): Deleted.
(WebCore::ElementInternals::ariaRoleDescription): Deleted.
(WebCore::ElementInternals::setAriaLabel): Deleted.
(WebCore::ElementInternals::ariaLabel): Deleted.
(WebCore::ElementInternals::setAriaValueForAttribute): Deleted.
(WebCore::ElementInternals::ariaValueForAttribute): Deleted.
(WebCore::ElementInternals::setAttributeWithoutSynchronization): Notify AX object cache.
(WebCore::ElementInternals::attributeWithoutSynchronization const):

* Source/WebCore/dom/ElementInternals.h:
* Source/WebCore/dom/ElementInternals.idl:

* Source/WebCore/dom/QualifiedName.h: Added the missing include for AtomStringHash.h.

Canonical link: https://commits.webkit.org/254549@main