[webkit-changes] [WebKit/WebKit] 3a0b78: Avoid bmalloc dependency when preprocessing Platfo...

Elliott Williams noreply at github.com
Thu Sep 15 23:54:58 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a0b78d146f938515fd815527d9f5497a869989c
      https://github.com/WebKit/WebKit/commit/3a0b78d146f938515fd815527d9f5497a869989c
  Author: Elliott Williams <emw at apple.com>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M Source/JavaScriptCore/jit/ExecutableAllocator.cpp
    M Source/JavaScriptCore/jit/ExecutableAllocator.h
    M Source/JavaScriptCore/jit/ExecutableMemoryHandle.h
    M Source/WTF/wtf/PlatformUse.h
    M Source/bmalloc/bmalloc/IsoHeapInlines.h

  Log Message:
  -----------
  Avoid bmalloc dependency when preprocessing Platform.h
https://bugs.webkit.org/show_bug.cgi?id=245256
rdar://91270496

Reviewed by Yusuke Suzuki and Alexey Proskuryakov.

Move LIBPAS_JIT_HEAP, the one platform feature that depends on bmalloc
headers, to JavaScriptCore. It's only read from JavaScriptCore, so this
does not require downstream changes.

As a result, Platform.h can be parsed without needing content from other
WebKit projects. This is important for projects which use Platform.h to
generate content during installhdrs. WebKitLegacy does while copying
headers (in migrate-header-rule). JavaScriptCore, WebCore, WebKit,
WebKitTestRunner, and DumpRenderTree all do this during their Generate
Derived Sources phase.

Rename USE_LIBPAS_JIT_HEAP to ENABLE_LIBPAS_JIT_HEAP to better reflect
how it's used.

* Source/JavaScriptCore/jit/ExecutableMemoryHandle.h:
* Source/WTF/wtf/PlatformUse.h:

* Source/JavaScriptCore/jit/ExecutableAllocator.cpp: Rename only.
* Source/JavaScriptCore/jit/ExecutableAllocator.h: Rename only.

* Source/bmalloc/bmalloc/IsoHeapInlines.h: Add a #include "BPlatform.h",
  as this header and some of its includes were relying on WTF's include.

Canonical link: https://commits.webkit.org/254543@main




More information about the webkit-changes mailing list