[webkit-changes] [WebKit/WebKit] b0895e: REGRESSION(250548 at main): Early WebProcess exit on ...

Olivier Blin noreply at github.com
Thu Sep 15 15:13:58 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0895ea02d480a799a9826620683d6b49ccdaf21
      https://github.com/WebKit/WebKit/commit/b0895ea02d480a799a9826620683d6b49ccdaf21
  Author: Olivier Blin <olivier.blin at softathome.com>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M Source/WTF/wtf/MemoryPressureHandler.cpp

  Log Message:
  -----------
  REGRESSION(250548 at main): Early WebProcess exit on 32-bit platforms since memory limit is zero
https://bugs.webkit.org/show_bug.cgi?id=245222

Reviewed by Ben Nham and Chris Dumez.

In 250548 at main, the memory limit in MemoryPressureHandler is set to a
least 7 GB for active process.
This value is stored in a size_t variable, but this is limited to 4 GB
on 32-bit platforms.

The memory limit is truncated down to 0, which triggers a WebProcess
exit after the first MemoryPressure check.

* Source/WTF/wtf/MemoryPressureHandler.cpp:
(WTF::thresholdForMemoryKillOfActiveProcess):
(WTF::thresholdForMemoryKillOfInactiveProcess):
Also use CPU(ADDRESS64)

Canonical link: https://commits.webkit.org/254533@main




More information about the webkit-changes mailing list