[webkit-changes] [WebKit/WebKit] e91c7b: Merge 254493 at main - html/browsers/browsing-the-web...

Chris Dumez noreply at github.com
Thu Sep 15 12:24:48 PDT 2022


  Branch: refs/heads/webkitgtk/2.36
  Home:   https://github.com/WebKit/WebKit
  Commit: e91c7be88b1336e36d694d60c17d590b92307674
      https://github.com/WebKit/WebKit/commit/e91c7be88b1336e36d694d60c17d590b92307674
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt
    M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  -----------
  Merge 254493 at main - html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html is failing in WebKit
https://bugs.webkit.org/show_bug.cgi?id=245163

Reviewed by Brent Fulgham.

The issue was that the loadType would get ignored in FrameLoader::loadItem()
when the navigation is same-document. As a result, m_loadType wouldn't get
set and FrameLoader::scrollToFragmentWithParentBoundary() would call
isSameDocumentReload() with an inaccurate loadType.

* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem):

Canonical link: https://commits.webkit.org/254493@main

(cherry picked from commit 3b0345e4d4e277783583964c2ff3b9697c5aa1cc)




More information about the webkit-changes mailing list