[webkit-changes] [WebKit/WebKit] 3375bc: Simplify CertificateInfo

EWS noreply at github.com
Thu Sep 15 12:00:29 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3375bc1aa4b62251277a10121629ecfb2a3cf86a
      https://github.com/WebKit/WebKit/commit/3375bc1aa4b62251277a10121629ecfb2a3cf86a
  Author: Alex Christensen <achristensen at webkit.org>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WTF/wtf/spi/cocoa/SecuritySPI.h
    M Source/WebCore/platform/network/cf/CertificateInfo.h
    M Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp
    M Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm
    M Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm
    M Source/WebCore/workers/service/server/SWServerJobQueue.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
    M Source/WebKit/Shared/API/c/mac/WKCertificateInfoMac.h
    M Source/WebKit/Shared/API/c/mac/WKCertificateInfoMac.mm
    M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp
    M Source/WebKit/Shared/cf/ArgumentCodersCF.h
    M Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm
    M Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Source/WebKit/UIProcess/Authentication/mac/WebCredentialMac.mm
    M Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm
    M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm

  Log Message:
  -----------
  Simplify CertificateInfo
https://bugs.webkit.org/show_bug.cgi?id=245184

Reviewed by Chris Dumez.

* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/spi/cocoa/SecuritySPI.h:
* Source/WebCore/platform/network/cf/CertificateInfo.h:
(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::certificateChain const):
(WebCore::CertificateInfo::isEmpty const):
* Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp:
(WebCore::CertificateInfo::secTrustFromCertificateChain):
(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate const):
(WebCore::CertificateInfo::summary const):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
(WebCore::CertificateInfo::type const): Deleted.
(WebCore::CertificateInfo::certificateChain const): Deleted.
(WTF::Persistence::encodeCertificateChain): Deleted.
* Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm:
(WebCore::CertificateInfo::dump const):
* Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformCertificateInfo const):
* Source/WebCore/workers/service/server/SWServerJobQueue.cpp:
(WebCore::doCertificatesMatch):
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
* Source/WebKit/Shared/API/c/mac/WKCertificateInfoMac.h:
* Source/WebKit/Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithServerTrust):
(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):
(WKCertificateInfoGetServerTrust):
* Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef):
(IPC::ArgumentCoder<CFTypeRef>::encode):
(IPC::ArgumentCoder<RetainPtr<CFTypeRef>>::decode):
* Source/WebKit/Shared/cf/ArgumentCodersCF.h:
* Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<WebCore::CertificateInfo>::encode):
(IPC::ArgumentCoder<WebCore::CertificateInfo>::decode):
(IPC::encodeNSError):
* Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm:
(-[WKObservablePageState serverTrust]):
* Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController certificateChain]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView serverTrust]):
(-[WKWebView _certificateChain]):
(-[WKWebView certificateChain]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _allowTLSCertificateChain:forHost:]):
* Source/WebKit/UIProcess/Authentication/mac/WebCredentialMac.mm:
(WebKit::leafCertificate):
(WebKit::chain):
* Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:
(WebKit::RemoteWebInspectorUIProxy::platformShowCertificate):
* Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:
(WebKit::WebInspectorUIProxy::platformShowCertificate):
* Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _certificateChain]):
(-[WKWebProcessPlugInFrame _serverTrust]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::showCertificate):

Canonical link: https://commits.webkit.org/254523@main




More information about the webkit-changes mailing list