[webkit-changes] [WebKit/WebKit] 3945f8: Merge 252526 at main - [ANGLE] Bounds check index buf...

kpiddington noreply at github.com
Thu Sep 15 03:54:07 PDT 2022


  Branch: refs/heads/webkitgtk/2.36
  Home:   https://github.com/WebKit/WebKit
  Commit: 3945f86ee5cb8c3a1f126821bf028914bcba4d35
      https://github.com/WebKit/WebKit/commit/3945f86ee5cb8c3a1f126821bf028914bcba4d35
  Author: Kyle Piddington <kpiddington at apple.com>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/format_autogen.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/gen_indices.metal
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/mtl_default_shaders_src_autogen.inc
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/mtl_default_shaders_src_autogen.metal

  Log Message:
  -----------
  Merge 252526 at main - [ANGLE] Bounds check index buffer generation
https://bugs.webkit.org/show_bug.cgi?id=242762

Bounds check element buffer access during triangle fan generation.
Out of bounds reads of the element buffer on both the CPU and GPU will result in getting back
index zero, rather than reading garbage memory

Reviewed by Dean Jackson.

* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.mm:
(rx::mtl::IndexGeneratorUtils::generateTriFanBufferFromElementsArray):
(rx::mtl::IndexGeneratorUtils::generateTriFanBufferFromElementsArrayGPU):
(rx::mtl::IndexGeneratorUtils::generateTriFanBufferFromElementsArrayCPU):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/format_autogen.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/gen_indices.metal:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/mtl_default_shaders_src_autogen.inc:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/mtl_default_shaders_src_autogen.metal:

Canonical link: https://commits.webkit.org/252526@main

(cherry picked from commit 7bf231b1fd3527ff9135e257bd192a004caa6548)




More information about the webkit-changes mailing list