[webkit-changes] [WebKit/WebKit] e65b45: Refactor CSSTransition::create() to only take Rend...
Antoine Quint
noreply at github.com
Thu Sep 15 02:11:13 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e65b4584d9c6610f4708c2600dba209ecadd9191
https://github.com/WebKit/WebKit/commit/e65b4584d9c6610f4708c2600dba209ecadd9191
Author: Antoine Quint <graouts at apple.com>
Date: 2022-09-15 (Thu, 15 Sep 2022)
Changed paths:
M Source/WebCore/animation/CSSTransition.cpp
M Source/WebCore/animation/CSSTransition.h
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/style/Styleable.cpp
Log Message:
-----------
Refactor CSSTransition::create() to only take RenderStyle references
https://bugs.webkit.org/show_bug.cgi?id=245177
Reviewed by Simon Fraser.
Before this patch, CSSTransition::create() would expect a `const RenderStyle*` for the oldStyle parameter,
but it makes no sense since a transition necessarily operates on an existing underlying style. So now we
make that parameter a `const RenderStyle&`.
We can also make a similar change to KeyframeEffect::computeCSSTransitionBlendingKeyframes().
* Source/WebCore/animation/CSSTransition.cpp:
(WebCore::CSSTransition::create):
* Source/WebCore/animation/CSSTransition.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeDeclarativeAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/style/Styleable.cpp:
(WebCore::updateCSSTransitionsForStyleableAndProperty):
Canonical link: https://commits.webkit.org/254510@main
More information about the webkit-changes
mailing list