[webkit-changes] [WebKit/WebKit] 4dc689: Hold the Scroll to the Text Fragment until a user ...

megangardner noreply at github.com
Thu Sep 15 01:05:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dc689b8cf6e04d32ec66f41d8c3d9615a7ec4a0
      https://github.com/WebKit/WebKit/commit/4dc689b8cf6e04d32ec66f41d8c3d9615a7ec4a0
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M Source/WebCore/page/FrameView.cpp
    M Source/WebCore/page/FrameView.h

  Log Message:
  -----------
  Hold the Scroll to the Text Fragment until a user scroll happens.
https://bugs.webkit.org/show_bug.cgi?id=245207
rdar://99668200

Reviewed by Tim Horton.

For each layout that comes in until the user scrolls we need to reset
the scroll to keep the fragment in the middle of the page.
Otherwise, more content can come in the scroll the fragment off the
page, which can be very confusing to the user.

* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::scrollToFragment):
(WebCore::FrameView::maintainScrollPositionAtRange):
(WebCore::FrameView::textFragmentIndicatorTimerFired):
(WebCore::FrameView::cancelScheduledTextFragmentIndicatorTimer):
(WebCore::FrameView::scrollToRange):
(WebCore::FrameView::performPostLayoutTasks):
* Source/WebCore/page/FrameView.h:

Canonical link: https://commits.webkit.org/254507@main




More information about the webkit-changes mailing list