[webkit-changes] [WebKit/WebKit] eb547e: Append ForTesting WKContextSetShouldUseFontSmoothi...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb547e04a18743efa5896ab697b1f74c3205d43c
      https://github.com/WebKit/WebKit/commit/eb547e04a18743efa5896ab697b1f74c3205d43c
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/FontCascade.cpp
    M Source/WebCore/platform/graphics/FontCascade.h
    M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/Shared/WebProcessCreationParameters.cpp
    M Source/WebKit/Shared/WebProcessCreationParameters.h
    M Source/WebKit/UIProcess/API/C/WKContext.cpp
    M Source/WebKit/UIProcess/API/C/WKContextPrivate.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/WebProcess.messages.in
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Append ForTesting WKContextSetShouldUseFontSmoothing to make it clearer that it's only used by WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=233978
<rdar://problem/86506527>

Reviewed by Myles C. Maxfield.

This also makes the global shouldUseFontSmoothingForTesting an atomic, since it can be read from
worker threads.

* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::setShouldUseSmoothingForTesting):
(WebCore::FontCascade::shouldUseSmoothingForTesting):
(WebCore::FontCascade::setShouldUseSmoothing): Deleted.
(WebCore::FontCascade::shouldUseSmoothing): Deleted.
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::FontCascade::drawGlyphs):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setFontSmoothingEnabled):
* Source/WebKit/Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Source/WebKit/Shared/WebProcessCreationParameters.h:
* Source/WebKit/UIProcess/API/C/WKContext.cpp:
(WKContextSetShouldUseFontSmoothingForTesting):
(WKContextSetShouldUseFontSmoothing): Deleted.
* Source/WebKit/UIProcess/API/C/WKContextPrivate.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::setShouldUseFontSmoothingForTesting):
(WebKit::WebProcessPool::setShouldUseFontSmoothing): Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setShouldUseFontSmoothingForTesting):
(WebKit::WebProcess::setShouldUseFontSmoothing): Deleted.
* Source/WebKit/WebProcess/WebProcess.h:
* Source/WebKit/WebProcess/WebProcess.messages.in:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(+[WebView _setShouldUseFontSmoothing:]): Deleted.
(+[WebView _shouldUseFontSmoothing]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

Canonical link: https://commits.webkit.org/254500@main