[webkit-changes] [WebKit/WebKit] fc2b16: Forgiving selectors should not be reported as supp...

Antti Koivisto noreply at github.com
Wed Sep 14 12:49:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc2b16c5035f0e6f974d06cccc8dc438db9e3dac
      https://github.com/WebKit/WebKit/commit/fc2b16c5035f0e6f974d06cccc8dc438db9e3dac
  Author: Antti Koivisto <antti at apple.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/resources/resource-files.json
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-format-001-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-format-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-tech-001-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-tech-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-whitespace-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-whitespace.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L4-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L4.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L5-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L5.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-selector-detecting-invalid-in-forgiving-argument-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-selector-detecting-invalid-in-forgiving-argument.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/supports-conditionText-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/supports-conditionText.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/w3c-import.log
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/w3c-import.log
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.h

  Log Message:
  -----------
  Forgiving selectors should not be reported as supported with CSS.supports("selector(...)")
https://bugs.webkit.org/show_bug.cgi?id=244808
<rdar://99682164>

Reviewed by Darin Adler.

CSS.supports() and @supports should return false for unrecognized selectors per CSSWG resolution in
https://github.com/w3c/csswg-drafts/issues/7280

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-format-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-format-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-tech-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-font-tech-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-whitespace-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-whitespace.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L4-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L4.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L5-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-L5.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-selector-detecting-invalid-in-forgiving-argument-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/CSS-supports-selector-detecting-invalid-in-forgiving-argument.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/supports-conditionText-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/supports-conditionText.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/w3c-import.log:

Also re-import wpt/css/css-conditional

* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumeForgivingSelectorList):
(WebCore::CSSSelectorParser::supportsComplexSelector):
* Source/WebCore/css/parser/CSSSelectorParser.h:

Canonical link: https://commits.webkit.org/254489@main




More information about the webkit-changes mailing list