[webkit-changes] [WebKit/WebKit] 6ae0bc: Scroll To Text Fragments fragments should alwasy b...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ae0bcb1c73ce6ea808e09557db62a0dbc5446d6
      https://github.com/WebKit/WebKit/commit/6ae0bcb1c73ce6ea808e09557db62a0dbc5446d6
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/Editor.h
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/editing/FrameSelection.h
    M Source/WebCore/page/FrameView.cpp

  Log Message:
  -----------
  Scroll To Text Fragments fragments should alwasy be scrolled to the cente of the screen.
https://bugs.webkit.org/show_bug.cgi?id=245169
<rdar://99904303>

Reviewed by Tim Horton.

Our code that scrolls selections into visible does not scroll them if they are already visible
at the current page scroll. We are wanting this to always go to the center so that it is easier
to hold the position, rather than have the scrolled text jump around a bit as additional content
is loaded in.

* Source/WebCore/editing/Editor.cpp:
(WebCore::TemporarySelectionChange::setSelection):
* Source/WebCore/editing/Editor.h:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
* Source/WebCore/editing/FrameSelection.h:
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::scrollToFragment):
(WebCore::FrameView::textFragmentIndicatorTimerFired):

Canonical link: https://commits.webkit.org/254477@main