[webkit-changes] [WebKit/WebKit] edad56: 'animation-foo' declarations in @keyframes should ...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edad56b68bd20b2e91cc54b6ad04c6d33d97124e
      https://github.com/WebKit/WebKit/commit/edad56b68bd20b2e91cc54b6ad04c6d33d97124e
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-allowed-properties-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-allowed-properties.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSKeyframesRule-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/rule-restrictions-expected.txt
    M Source/WebCore/css/CSSKeyframesRule.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h

  Log Message:
  -----------
  'animation-foo' declarations in @keyframes should be parse error
https://bugs.webkit.org/show_bug.cgi?id=243537
<rdar://98503617>

Reviewed by Antti Koivisto.

The family of animation-* properties, including the animation shorthand, are
invalid in a @keyframes rule. We import the relevant WPT test which used to
fail but now passes as of this change. Some other existing tests need rebasing
since we changed the serialization to not output the vendor prefix, and also
because they are passing thanks to this change.

* LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-allowed-properties-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-allowed-properties.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSKeyframesRule-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/rule-restrictions-expected.txt:
* Source/WebCore/css/CSSKeyframesRule.cpp:
(WebCore::CSSKeyframesRule::cssText const):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseValue):
(WebCore::CSSPropertyParser::parseKeyframeDescriptor):
* Source/WebCore/css/parser/CSSPropertyParser.h:

Canonical link: https://commits.webkit.org/254468@main